Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 7, Fall 8, Fall 9
Description
Situation: When someone navigates to an app on the IGB App Store (apps.bioviz.org) without IGB open, a button is present on the right side of the screen which reads "Get latest IGB". Clicking on this button does something unexpected: it reroutes the current tab to bioviz.org and it also opens a new tab to bioviz.org at the same time, resulting in two bioviz.org tabs opening from one button click.
Task: Look into why the button is opening bioviz.org twice and then implement a fix.
Expected behavior: Clicking the "Get latest IGB" button reroutes the page to the downloads page, not bioviz.org, such that someone can download IGB then click the back arrow and navigate back to apps.bioviz.org.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-3014 [ 21526 ] |
| Rank | Ranked lower |
| Assignee | Paige Kulzer [ pkulzer ] | Pranav Bhatia [ pbhatia1 ] |
| Sprint | Fall 7 [ 230 ] | |
| Assignee | Pranav Bhatia [ pbhatia1 ] | Paige Kulzer [ pkulzer ] |
| Description |
*Situation:* When someone navigates to an app on the IGB App Store (apps.bioviz.org) without IGB open, a button is present on the right side of the screen which reads "Get latest IGB". Clicking on this button does something unexpected: it reroutes the current tab to bioviz.org and it also opens a new tab to bioviz.org at the same time, resulting in two bioviz.org tabs opening from one button click.
*Task:* Look into why the button is opening bioviz.org twice and then implement a fix. *Expected behavior:* Clicking the "Get latest IGB" button reroutes the page to bioviz.org such that someone can click the back arrow and navigate back to apps.bioviz.org. |
*Situation:* When someone navigates to an app on the IGB App Store (apps.bioviz.org) without IGB open, a button is present on the right side of the screen which reads "Get latest IGB". Clicking on this button does something unexpected: it reroutes the current tab to bioviz.org and it also opens a new tab to bioviz.org at the same time, resulting in two bioviz.org tabs opening from one button click.
*Task:* Look into why the button is opening bioviz.org twice and then implement a fix. *Expected behavior:* Clicking the "Get latest IGB" button reroutes the page to the downloads page, not bioviz.org, such that someone can download IGB then click the back arrow and navigate back to apps.bioviz.org. |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Sprint | Fall 7 [ 230 ] | Fall 7, Fall 8 [ 230, 231 ] |
| Rank | Ranked higher |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Testing App Store on Mac by clicking the Get latest IGB button:
Branch Version:
- No IGB - New tab opens with bioviz.org/download.html. Original tab remains on App Store.
- IGB 9.0.2 - New tab opens with bioviz.org/download.html. Original tab remains on App Store.
- A link at the top of the page appears "Please update to a newer version of IGB @ Click Here". When I click Here a new tab opens with bioviz.org/download.html. Original tab remains on App Store.
- IGB 9.1.10 - Nothing happens
- IGB 10.1.0 - Button changes to installing the app
Release Version:
- No IGB - New tab opens with bioviz.org. Original tab changes to bioviz.org.
- IGB 9.0.2 - New tab opens with bioviz.org. Original tab changes to bioviz.org.
- A link at the top of the page appears "Please update to a newer version of IGB @ Click Here". When I click Here a new tab opens with bioviz.org/download.html. Original tab remains on App Store.
- IGB 9.1.10 - Same tab navigates to BioViz.org
- IGB 10.1.0 - Button changes to installing the app
The only issue that I could find is when the version of IGB is high enough that the App Store recognizes IGB as being compatible with the app store, but the app itself requires a higher version of IGB. On the branch version the Get latest IGB button fails to respond.
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
I recreated this issue on my machine using IGB 9.1.10 and the GenArk Genomes App which requires IGB 10+. I was able to find the function that handles the logic for this and made a small change to fix the button. This has been merged into my previous commit since it's such a small change.
Ready for review!
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
During testing, Dr. Freese observed that the button was not responsive when on an app page other than that of GenArk Genomes which is what I tested with. By removing one of the calls to the downloads page and preventing duplicate windows opening, I had to then also change the behavior of the button to trigger the other call to the downloads page.
Ready for another round of review.
Tested locally on Mac using the instructions above.
Get latest IGB button working as expected.
Ready for PR.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Ann Loraine [ aloraine ] |
| Sprint | Fall 7, Fall 8 [ 230, 231 ] | Fall 7, Fall 8, Fall 9 [ 230, 231, 232 ] |
| Rank | Ranked higher |
Since we can't test this in a production-like environment with the diversity of Apps that are available on the main site, I don't want to merge this yet.
So, I have a request for Paige Kulzer:
Could you please submit the PR to the appstore code repository as a new branch so that we can keep your work on hand and merge it later once I get the app store playbooks updated?
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] | Paige Kulzer [ pkulzer ] |
| Link | This issue is blocked by IGBF-4328 [ IGBF-4328 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
I've declined the original PR and have made a new one which copies the branch over to the Loraine Lab appstore repo: https://bitbucket.org/lorainelab/appstore/pull-requests/291
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] | Paige Kulzer [ pkulzer ] |
| Assignee | Paige Kulzer [ pkulzer ] | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
Thank you! I have added the new branch to the Loraine Lab App Store repository.
Moving to DONE.
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Ann Loraine [ aloraine ] | Paige Kulzer [ pkulzer ] |
Branch: https://bitbucket.org/pkulzer-lorainelab/appstore/branch/IGBF-4050
The "Get latest IGB" button should no longer open two different windows when clicked. Instead, it should open a new tab to bioviz.org/download.html and leave the app store window open.
Ready for review! Testing might be difficult since it requires the setup of a local app store instance, instructions for which can be found in
IGBF-4275or here: https://docs.google.com/document/d/1_9C03q6TD5wjLqfVLKsuDsIEQ4-qrS0JhONO5VBOwaA