Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 10.2.0
    • Labels:
      None

      Description

      Investigate and create a reusable UI that can be extended by other modules and use the UI to load and search the genomes from the external data provider. Also, create a POC ucsc-genark plugin app and extend this UI to implement it.

        Attachments

          Issue Links

            Activity

            Hide
            jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - - edited

            Created a reusable UI for all the external data providers, the code for that is present in the integrated genome browser and the external providers can implement the interface and use the GUI class to use the UI. Also, created a new plugin app for the UCSC GenArk provider with simple implementation, the integration will be done in further tickets. Here is the updated code:
            https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-4089
            https://bitbucket.org/jaya-sravani/ucsc-genark-data-provider/src/main/
            Below is a screenshot of the UI:

            Will get this reviewed with Nowlan Freese and make any necessary changes if needed.

            Show
            jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - - edited Created a reusable UI for all the external data providers, the code for that is present in the integrated genome browser and the external providers can implement the interface and use the GUI class to use the UI. Also, created a new plugin app for the UCSC GenArk provider with simple implementation, the integration will be done in further tickets. Here is the updated code: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-4089 https://bitbucket.org/jaya-sravani/ucsc-genark-data-provider/src/main/ Below is a screenshot of the UI: Will get this reviewed with Nowlan Freese and make any necessary changes if needed.
            Hide
            jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - - edited

            Added the info column as discussed and also added enabling and disabling the previous and next buttons based on the availability of the rows. Here is the updated code:
            https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-4089
            https://bitbucket.org/jaya-sravani/ucsc-genark-data-provider/src/main/

            To test:

            • Pull both the branches in your local.
            • Build and run IGB from the given branch.
            • Build the ucsc-genark-data-provider service as well using "mvn clean install"
            • Now add the data provder as a plugin in IGB, while choosing the folder choose the generated target folder of the ucsc-genark-data-provider service.

            Please review the UI and let me know if you have any suggestions.

            Show
            jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - - edited Added the info column as discussed and also added enabling and disabling the previous and next buttons based on the availability of the rows. Here is the updated code: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-4089 https://bitbucket.org/jaya-sravani/ucsc-genark-data-provider/src/main/ To test: Pull both the branches in your local. Build and run IGB from the given branch. Build the ucsc-genark-data-provider service as well using "mvn clean install" Now add the data provder as a plugin in IGB, while choosing the folder choose the generated target folder of the ucsc-genark-data-provider service. Please review the UI and let me know if you have any suggestions.
            Hide
            nfreese Nowlan Freese added a comment -
            Show
            nfreese Nowlan Freese added a comment - Example description.html that the "i" icon will link out to: https://hgdownload.soe.ucsc.edu/hubs/GCA/000/001/905/GCA_000001905.1/html/GCA_000001905.1_Loxafr3.0.description.html
            Hide
            nfreese Nowlan Freese added a comment - - edited

            Tested using Sravani's branches on Mac
            Everything is working as expected at this time. We met to discuss some changes to the user interface. Suggestions below. Jaya Sravani Sirigineedi - feel free to create new tickets from the suggestions or add them to this ticket, up to you.

            • Enable sorting of the column names, for example alphabetically sorting by "Scientific Name".
            • Move the "Clear Search" button to the top of the app to the right of the search bar.
            • Make columns extensible so that an app can add additional columns as needed. For example, right now the columns are Common Name, Scientific Name, Assembly Version. For UCSC GenArk we would also like to include Accession, taxonId, and GenArk Clade.
            • Increase the default number of rows visible to 100.
              • Make the rows of the table scrollable.

            UPDATE: Did code review with Sravani. Changes above will be implemented as separate tickets. Code for this ticket should be merged.

            Ready for PR

            Show
            nfreese Nowlan Freese added a comment - - edited Tested using Sravani's branches on Mac Everything is working as expected at this time. We met to discuss some changes to the user interface. Suggestions below. Jaya Sravani Sirigineedi - feel free to create new tickets from the suggestions or add them to this ticket, up to you. Enable sorting of the column names, for example alphabetically sorting by "Scientific Name". Move the "Clear Search" button to the top of the app to the right of the search bar. Make columns extensible so that an app can add additional columns as needed. For example, right now the columns are Common Name, Scientific Name, Assembly Version. For UCSC GenArk we would also like to include Accession, taxonId, and GenArk Clade. Increase the default number of rows visible to 100. Make the rows of the table scrollable. UPDATE: Did code review with Sravani. Changes above will be implemented as separate tickets. Code for this ticket should be merged. Ready for PR
            Hide
            jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - - edited

            Created two separate tickets for the improvements based on their difficulty, linked all the related tickets to this. As the scope of this ticket is completed and review is done, raised a pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1061. Please review and let me know if there are any issues. As the actual implementation is not done yet, won't be raising a pull request for the ucsc-genark-provider repo.

            Show
            jsirigin Jaya Sravani Sirigineedi (Inactive) added a comment - - edited Created two separate tickets for the improvements based on their difficulty, linked all the related tickets to this. As the scope of this ticket is completed and review is done, raised a pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1061 . Please review and let me know if there are any issues. As the actual implementation is not done yet, won't be raising a pull request for the ucsc-genark-provider repo.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            PR is merged, new installers are built and deployed to early access section on bioviz.org.
            Ready for testing.

            Show
            ann.loraine Ann Loraine added a comment - - edited PR is merged, new installers are built and deployed to early access section on bioviz.org. Ready for testing.
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on Mac with main branch installer.

            • Note: I had an issue with building the GenArk app. The issue was resolved after I built the IGB 10.2.0 main branch locally. This seems odd?
            • Able to add the GenArk app and run it successfully. No errors in the log.

            Closing ticket

            Show
            nfreese Nowlan Freese added a comment - Tested on Mac with main branch installer. Note: I had an issue with building the GenArk app. The issue was resolved after I built the IGB 10.2.0 main branch locally. This seems odd? Able to add the GenArk app and run it successfully. No errors in the log. Closing ticket
            Hide
            ann.loraine Ann Loraine added a comment -

            Update:

            Ann Loraine requested that Jaya Sravani Sirigineedi implement bitbucket pipeline build process for her repository. Also, Ann Loraine forked her repository into the Loraine Lab workspace.

            As per discussion in today's scrum and yesterday via email, Jaya Sravani Sirigineedi decided to stop using repository variable

            ${BB_AUTH_STRING}
            

            in the bitbucket pipeline script and change to using

            ${BITBUCKET_USERNAME}:${BITBUCKET_APP_PASSWORD} 
            

            instead because this is more consistent with the Atlassian bitbucket cloud documentation and also is more intuitive for users, because our individual accounts have "app password" options in our bitbucket user account settings.

            She also investigated whether BITBUCKET_USERNAME environment variable is provided in the pipeline environment. It is not. So, we need to set both variables as repository environment variables for the pipeline to run.

            We both had an issue with remembering how to create BB_AUTH_STRING. It's supposed to be a concatenation of a user name and an app password, with a colon character. This is hard to remember and easy to forget.

            Jaya Sravani Sirigineedi reimplemented the pipeline code and I have updated the lorainelab fork. The pipeline ran as expected and new artifacts were built and transferred the the Download section as expeced.

            Show
            ann.loraine Ann Loraine added a comment - Update: Ann Loraine requested that Jaya Sravani Sirigineedi implement bitbucket pipeline build process for her repository. Also, Ann Loraine forked her repository into the Loraine Lab workspace. As per discussion in today's scrum and yesterday via email, Jaya Sravani Sirigineedi decided to stop using repository variable ${BB_AUTH_STRING} in the bitbucket pipeline script and change to using ${BITBUCKET_USERNAME}:${BITBUCKET_APP_PASSWORD} instead because this is more consistent with the Atlassian bitbucket cloud documentation and also is more intuitive for users, because our individual accounts have "app password" options in our bitbucket user account settings. She also investigated whether BITBUCKET_USERNAME environment variable is provided in the pipeline environment. It is not. So, we need to set both variables as repository environment variables for the pipeline to run. We both had an issue with remembering how to create BB_AUTH_STRING. It's supposed to be a concatenation of a user name and an app password, with a colon character. This is hard to remember and easy to forget. Jaya Sravani Sirigineedi reimplemented the pipeline code and I have updated the lorainelab fork. The pipeline ran as expected and new artifacts were built and transferred the the Download section as expeced.

              People

              • Assignee:
                jsirigin Jaya Sravani Sirigineedi (Inactive)
                Reporter:
                jsirigin Jaya Sravani Sirigineedi (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: