Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 10.2.0
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 6, Fall 7
Description
Situation: I've noticed that the columns in the GenArk Genomes table are not able to be resized. I think this would be a nice improvement to make, especially because the information in the Common Name column is often quite lengthy.
Task: Investigate the ability to resize columns in the GenArk Genomes table.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-4086 [ 23382 ] |
| Assignee | Paige Kulzer [ pkulzer ] |
| Sprint | Fall 6 [ 229 ] | Fall 6, Fall 7 [ 229, 230 ] |
| Rank | Ranked higher |
| Assignee | Paige Kulzer [ pkulzer ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Tested on Paige's branch. Columns can be resized. Default behavior and column width are good. Everything else appears to be working.
Paige Kulzer - Please make one change to your commit. On line 7 there is the following import:
javax.swing.*;
Please revert to the old import and avoid the use of "*" imports. This is most likely something your IDE did without asking, I think there is a setting you have to change in IntelliJ.
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Thank you for letting me know! It was an automatic change by my IDE. I think I've fixed that setting so it shouldn't be an issue in the future.
My commit has been updated, so I will now raise a PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1085
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
PR is merged and new installers are built and deployed to bioviz.org early access section. Ready for final testing.
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Nowlan Freese [ nfreese ] |
Tested early access installer on Mac.
Columns can be resized, working as expected.
Closing ticket.
| Assignee | Nowlan Freese [ nfreese ] | Paige Kulzer [ pkulzer ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Fix Version/s | 10.2.0 [ 11100 ] |
Branch: https://bitbucket.org/pkulzer-lorainelab/integrated-genome-browser/branch/IGBF-4322
Sravani created a file in the IGB code base called GenomeDynamicSearchTableGUI.java which contains the code for initializing and resizing column widths in the GenArk Genomes table. I've added the following line of code which allows the columns to be resizable while still maintaining the overall size/look of the GenArk Genomes table:
Ready for review!