Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4376

Fix closing of Color By window when Import window open freezes IGB

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Situation: IGB is freezing if the Color By SAMtags window is closed while the import window is still open.

          Task: Fix it so that the Color By SAMtags window cannot be closed while the import window is open.

          Note: I tested the earlier version of the import window prior to it being changed to the JavaFX version used throughout IGB. The earlier version did not allow the user to close the parent window while the import window was open. Other save/import/export JavaFX windows in IGB also do not let the user close the parent window.

          To reproduce: In the Color By > SAMtags window, click Import... Then, without clicking anything in the file finder that comes up, close out both of the SAMtags Color By windows, then close the file finder.
          Result: IGB freezes and needs to be force quit.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-4295 Add the ability to include cluster information to SAMtools tags Color by feature

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                Deepthi provided code changes here: https://bitbucket.org/lorainelab-deepthi/integrated-genome-browser/branch/IGBF-4371_1

                I reviewed these changes locally and found this issue to be fixed. I then amended the original commit message and branch name to align them with this ticket number and have created a PR.

                PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1091

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - Deepthi provided code changes here: https://bitbucket.org/lorainelab-deepthi/integrated-genome-browser/branch/IGBF-4371_1 I reviewed these changes locally and found this issue to be fixed. I then amended the original commit message and branch name to align them with this ticket number and have created a PR. PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1091
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                PR is merged.

                Show
                ann.loraine Ann Loraine added a comment - PR is merged.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Installers are built and deployed to bioviz.org early access section as usual.

                Ready for testing.

                Show
                ann.loraine Ann Loraine added a comment - Installers are built and deployed to bioviz.org early access section as usual. Ready for testing.
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                Downloaded the Early Access installer and tested on my Mac. Unable to interact with any of the Color By windows when the File Chooser is open which is the desired behavior. No errors in the Log.

                Closing ticket!

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - Downloaded the Early Access installer and tested on my Mac. Unable to interact with any of the Color By windows when the File Chooser is open which is the desired behavior. No errors in the Log. Closing ticket!

                  People

                  • Assignee:
                    karthik Karthik Raveendran
                    Reporter:
                    nfreese Nowlan Freese
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: