Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 9
Description
Situation: IGB is freezing if the Color By SAMtags window is closed while the import window is still open.
Task: Fix it so that the Color By SAMtags window cannot be closed while the import window is open.
Note: I tested the earlier version of the import window prior to it being changed to the JavaFX version used throughout IGB. The earlier version did not allow the user to close the parent window while the import window was open. Other save/import/export JavaFX windows in IGB also do not let the user close the parent window.
To reproduce: In the Color By > SAMtags window, click Import... Then, without clicking anything in the file finder that comes up, close out both of the SAMtags Color By windows, then close the file finder.
Result: IGB freezes and needs to be force quit.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-3765 [ 22984 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Ann Loraine [ aloraine ] |
PR is merged.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
Installers are built and deployed to bioviz.org early access section as usual.
Ready for testing.
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Assignee | Paige Kulzer [ pkulzer ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Downloaded the Early Access installer and tested on my Mac. Unable to interact with any of the Color By windows when the File Chooser is open which is the desired behavior. No errors in the Log.
Closing ticket!
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Paige Kulzer [ pkulzer ] | Karthik Raveendran [ karthik ] |
Deepthi provided code changes here: https://bitbucket.org/lorainelab-deepthi/integrated-genome-browser/branch/IGBF-4371_1
I reviewed these changes locally and found this issue to be fixed. I then amended the original commit message and branch name to align them with this ticket number and have created a PR.
PR: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1091