Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-4379

User entered values in the Color By SAMtags should be auto-checked

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Situation: When a user enters a manual tag value in the Color By > SAMtags window, the row remains unchecked. This could confuse users.

          Task: Fix it so that when a user enters a value the row is automatically checked.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-4295 Add the ability to include cluster information to SAMtools tags Color by feature

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                nfreese Nowlan Freese created issue -
                nfreese Nowlan Freese made changes -
                Field Original Value New Value
                Epic Link IGBF-3765 [ 22984 ]
                nfreese Nowlan Freese made changes -
                Link This issue relates to IGBF-4295 [ IGBF-4295 ]
                karthik Karthik Raveendran made changes -
                Status To-Do [ 10305 ] In Progress [ 3 ]
                Hide
                Permalink
                karthik Karthik Raveendran added a comment -

                Issue fixed in c953b12

                Show
                karthik Karthik Raveendran added a comment - Issue fixed in c953b12
                karthik Karthik Raveendran made changes -
                Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
                karthik Karthik Raveendran made changes -
                Assignee Paige Kulzer [ pkulzer ]
                pkulzer Paige Kulzer (Inactive) made changes -
                Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                Tested locally, this change seems to be working well! Adding a Tag Value automatically checks the checkbox, and deleting a tag unchecks the checkbox. User input is still maintained between closing and reopening of the Color By window. No errors in the Log.

                Recommending PR!

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - Tested locally, this change seems to be working well! Adding a Tag Value automatically checks the checkbox, and deleting a tag unchecks the checkbox. User input is still maintained between closing and reopening of the Color By window. No errors in the Log. Recommending PR!
                pkulzer Paige Kulzer (Inactive) made changes -
                Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
                pkulzer Paige Kulzer (Inactive) made changes -
                Assignee Paige Kulzer [ pkulzer ] Karthik Raveendran [ karthik ]
                Hide
                Permalink
                karthik Karthik Raveendran added a comment -

                PR submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1095

                Show
                karthik Karthik Raveendran added a comment - PR submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/1095
                karthik Karthik Raveendran made changes -
                Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
                karthik Karthik Raveendran made changes -
                Assignee Karthik Raveendran [ karthik ]
                pkulzer Paige Kulzer (Inactive) made changes -
                Assignee Ann Loraine [ aloraine ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                PR is merged.

                Show
                ann.loraine Ann Loraine added a comment - PR is merged.
                ann.loraine Ann Loraine made changes -
                Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Installers are built and deployed to bioviz.org early access section. Ready for testing.

                Show
                ann.loraine Ann Loraine added a comment - Installers are built and deployed to bioviz.org early access section. Ready for testing.
                ann.loraine Ann Loraine made changes -
                Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
                ann.loraine Ann Loraine made changes -
                Assignee Ann Loraine [ aloraine ]
                pkulzer Paige Kulzer (Inactive) made changes -
                Assignee Paige Kulzer [ pkulzer ]
                pkulzer Paige Kulzer (Inactive) made changes -
                Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
                Hide
                Permalink
                pkulzer Paige Kulzer (Inactive) added a comment -

                Downloaded the Early Access installer to my Mac for testing. All rows with a tag value are being automatically checked. This holds true for manual entries as well as imported entries. Deleting an entry still unchecks the box and adding only a cluster and/or color does not check the box. Color by functionality is still working as expected. No errors in the Log.

                Closing ticket!

                Show
                pkulzer Paige Kulzer (Inactive) added a comment - Downloaded the Early Access installer to my Mac for testing. All rows with a tag value are being automatically checked. This holds true for manual entries as well as imported entries. Deleting an entry still unchecks the box and adding only a cluster and/or color does not check the box. Color by functionality is still working as expected. No errors in the Log. Closing ticket!
                pkulzer Paige Kulzer (Inactive) made changes -
                Resolution Done [ 10000 ]
                Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
                pkulzer Paige Kulzer (Inactive) made changes -
                Assignee Paige Kulzer [ pkulzer ] Karthik Raveendran [ karthik ]

                  People

                  • Assignee:
                    karthik Karthik Raveendran
                    Reporter:
                    nfreese Nowlan Freese
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: