Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-898

IPS results spans may be missing complete label information

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Some IPS result spans may have labels that are cut off (ex: "Span 1 of").

      To examine this problem you may want to look at a gene id "NM_001144822" under the human genome (Chr1).

      View the attached screenshots to help visualize the problem.

      To reproduce:

      1) Start ProtAnnot for the gene outlined above (NM_001144822).
      2) Run "TMHMM" under InterProScan.

      *Observe:

      Some of the spans (as seen in the screenshots) just say "Span 1 of".

        Attachments

          Issue Links

            Activity

            mason Mason Meyer (Inactive) created issue -
            mason Mason Meyer (Inactive) made changes -
            Field Original Value New Value
            Epic Link IGBF-594 [ 15667 ]
            mason Mason Meyer (Inactive) made changes -
            Link This issue relates to IGBF-845 [ IGBF-845 ]
            mason Mason Meyer (Inactive) made changes -
            Description Some IPS result spans may have labels that are cut off (ex: "Span 1 of").

            To examine this problem you may want to look at a gene id "NM_001144822" under the human genome (Chr1).

            View the attached screenshots to help visualize the problem.

            To reproduce:

            1) Start ProtAnnot for the gene outlined above (NM_001144822).
            2) Run "TMHMM" under InterProScan.

            *Observe:

            Some of the spans (as seen in the screenshots) just say "Span 1 of".
            mason Mason Meyer (Inactive) made changes -
            Attachment Span1of.PNG [ 13162 ]
            Attachment Span1ofProblem.PNG [ 13163 ]
            mason Mason Meyer (Inactive) made changes -
            Rank Ranked higher
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked lower
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            dcnorris David Norris (Inactive) made changes -
            Sprint Backlog Grooming Meeting [ 34 ] Backlog Grooming Meeting 2 [ 35 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            dcnorris David Norris (Inactive) made changes -
            Sprint Backlog Grooming Meeting 2 [ 35 ] Sprint 26 [ 34 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            Hide
            mason Mason Meyer (Inactive) added a comment -

            It has been decided that the "of" in "Span 1 of" should be removed for IPS result spans that do not contain a full statement, as described in the description of this story.

            Show
            mason Mason Meyer (Inactive) added a comment - It has been decided that the "of" in "Span 1 of" should be removed for IPS result spans that do not contain a full statement, as described in the description of this story.
            mason Mason Meyer (Inactive) made changes -
            Status Open [ 1 ] Needs Testing [ 10002 ]
            mason Mason Meyer (Inactive) made changes -
            Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
            mason Mason Meyer (Inactive) made changes -
            Link This issue relates to IGBF-922 [ IGBF-922 ]
            mason Mason Meyer (Inactive) made changes -
            Labels ProtAnnot
            Hide
            mason Mason Meyer (Inactive) added a comment -

            This issue should not be tested until issue IGBF-922 is also ready for testing since they touch the same parts of the code.

            Show
            mason Mason Meyer (Inactive) added a comment - This issue should not be tested until issue IGBF-922 is also ready for testing since they touch the same parts of the code.
            mason Mason Meyer (Inactive) made changes -
            Status Testing In Progress [ 10003 ] Needs Testing [ 10002 ]
            mason Mason Meyer (Inactive) made changes -
            Rank Ranked lower
            mason Mason Meyer (Inactive) made changes -
            Status Needs Testing [ 10002 ] Testing Blocked [ 10201 ]
            mason Mason Meyer (Inactive) made changes -
            Status Testing Blocked [ 10201 ] Testing In Progress [ 10003 ]
            mason Mason Meyer (Inactive) made changes -
            Assignee Mason Meyer [ mason ]
            Hide
            mason Mason Meyer (Inactive) added a comment -

            It seems that there is still a case where a span may be missing label information. The team will discuss this to find a solution for this problem.

            Show
            mason Mason Meyer (Inactive) added a comment - It seems that there is still a case where a span may be missing label information. The team will discuss this to find a solution for this problem.
            mason Mason Meyer (Inactive) made changes -
            Status Testing In Progress [ 10003 ] Testing Blocked [ 10201 ]
            Hide
            mason Mason Meyer (Inactive) added a comment - - edited

            From Ann:

            This is one of the most important signature libraries in InterPro – and so it is great that you're looking into this.

            For cases like this where is no name field in the XML, use the "ac" field. If there is no value in the "ac" field, then use the "library" attribute in the signature-library-release fields.

            Show
            mason Mason Meyer (Inactive) added a comment - - edited From Ann: This is one of the most important signature libraries in InterPro – and so it is great that you're looking into this. For cases like this where is no name field in the XML, use the "ac" field. If there is no value in the "ac" field, then use the "library" attribute in the signature-library-release fields.
            Hide
            mason Mason Meyer (Inactive) added a comment -

            This issue will be reassigned to John so that he can make changes as requested by Ann.

            Show
            mason Mason Meyer (Inactive) added a comment - This issue will be reassigned to John so that he can make changes as requested by Ann.
            mason Mason Meyer (Inactive) made changes -
            Assignee Mason Meyer [ mason ] John Eckstein [ jeckstein ]
            mason Mason Meyer (Inactive) made changes -
            Status Testing Blocked [ 10201 ] Open [ 1 ]
            jeckstein John Eckstein (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jeckstein John Eckstein (Inactive) made changes -
            Status In Progress [ 3 ] Needs Testing [ 10002 ]
            jeckstein John Eckstein (Inactive) made changes -
            Status Needs Testing [ 10002 ] In Progress [ 3 ]
            jeckstein John Eckstein (Inactive) made changes -
            Status In Progress [ 3 ] Needs Testing [ 10002 ]
            jeckstein John Eckstein (Inactive) made changes -
            Assignee John Eckstein [ jeckstein ] Mason Meyer [ mason ]
            mason Mason Meyer (Inactive) made changes -
            Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 26 [ 34 ]
            dcnorris David Norris (Inactive) made changes -
            Sprint Sprint 27 [ 35 ]
            dcnorris David Norris (Inactive) made changes -
            Rank Ranked higher
            Hide
            mason Mason Meyer (Inactive) added a comment - - edited

            Testing for this issue included:

            1) Verifying that "Span 1 of" is removed for spans that do not contain a full statement.
            2) Verify that the label reads the correct name of the span based on the XML file or it uses the "ac" field if no name is given.
            3) Verifying that no other label information was affected when fixing this issue.

            Since this issue is resolved it will now be closed.

            Show
            mason Mason Meyer (Inactive) added a comment - - edited Testing for this issue included: 1) Verifying that "Span 1 of" is removed for spans that do not contain a full statement. 2) Verify that the label reads the correct name of the span based on the XML file or it uses the "ac" field if no name is given. 3) Verifying that no other label information was affected when fixing this issue. Since this issue is resolved it will now be closed.
            mason Mason Meyer (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Testing In Progress [ 10003 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 16308 ] Fall 2019 Workflow Update [ 19630 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 19630 ] Revised Fall 2019 Workflow Update [ 21749 ]

              People

              • Assignee:
                mason Mason Meyer (Inactive)
                Reporter:
                mason Mason Meyer (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: