Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1
-
Sprint:Winter 2018 Sprint 3, Spring 2019 Sprint 1
Description
User story:
"When I right click an item (Glyph) in a track, a context menu appears.
One of the options is "Search Web"
If I select "Search Web," a new menu appears (a submenu) with links to sites.
The order of the sites shown changes apparently at random as I repeat this action with the same or different items.
This is confusing because it doesn't let me learn where to find a particular option.
This should be fixed to ensure that menu items always appear in the same location in the menu."
To reproduce:
- Load an Annotation track (Araport11 from A_thaliana_Jun_2009 genome version)
- Right-click on item in the track.
- Choose the "web search" option to activate a sub-menu.
- Note there are two options: "TAIR" and "Google"
- Repeat. Note that "TAIR" and "Google" are listed in a different order from before
Task:
- Find out why this random sorting is occurring.
- Propose a fix here (add a Comment).
- Create a new Jira issue (Improvement) for implementing the proposed fix. (Link this issue for instructions on how to do it.)
Attachments
Issue Links
- relates to
-
IGBF-1540 Investigate: Order Get Info and Google right-click menu items
-
- To-Do
-
Activity
1st Level Review:
Issue appears fixed. The sites are now ordered in "Search Web". Kiran also noticed that the "Get Info" and "Search Web" menu items were also themselves unordered and would flip randomly. They are now ordered as well.
Needs a fix to the commit, then it should be ready for a pull request.
Can you take a look at the commit now?
https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1155-context-menu
Commit looks good, moving to ready for pull request.
Merged to master.
Testing Mac: Working Correctly
Note: In the right click menu, the Get Info and Google menu options are unordered. This was not part of this issue, but would be related. A new issue has been raised IGBF-1540.
Testing Windows: Working Correctly
Note: In the right click menu, the Get Info and Google menu options are not ordered. This was not part of this issue, but would be related. This issue raised has been raised: IGBF-1540
Testing Linux: Working Correctly
Note: In the right click menu, the Get Info and Google menu options are unordered. This was not part of this issue, but would be related. A new issue has been raised IGBF-1540.
The random sorting was due to the use of SET, which is an unordered collection.
Changing to different collection affects a lot of places.
So, sorting based on the label of the menu item is performed, before adding to the Jmenu.
Need a first level review for this branch.
https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1155-context-menu
Thanks.