Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1
-
Sprint:Winter 2018 Sprint 3, Spring 2019 Sprint 1
Description
User story:
"When I right click an item (Glyph) in a track, a context menu appears.
One of the options is "Search Web"
If I select "Search Web," a new menu appears (a submenu) with links to sites.
The order of the sites shown changes apparently at random as I repeat this action with the same or different items.
This is confusing because it doesn't let me learn where to find a particular option.
This should be fixed to ensure that menu items always appear in the same location in the menu."
To reproduce:
- Load an Annotation track (Araport11 from A_thaliana_Jun_2009 genome version)
- Right-click on item in the track.
- Choose the "web search" option to activate a sub-menu.
- Note there are two options: "TAIR" and "Google"
- Repeat. Note that "TAIR" and "Google" are listed in a different order from before
Task:
- Find out why this random sorting is occurring.
- Propose a fix here (add a Comment).
- Create a new Jira issue (Improvement) for implementing the proposed fix. (Link this issue for instructions on how to do it.)
Attachments
Issue Links
- relates to
-
IGBF-1540 Investigate: Order Get Info and Google right-click menu items
-
- To-Do
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Ann Loraine [ aloraine ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Summary | right-click menu items should be ordered | Make right-click menu items consistent between uses |
| Description |
When I right click a track name, the items in the menu are consistently in the same order.
This is great, I subconsciously anticipate where my favorite button will be as I right click. When I click on gene annotations, or reads, the menu sections (separated by horizontal gray lines) are in a consistent order, but most of the sections randomly order their 2-3 members. Right-click on a gene model, hover over the "web search" option to get that sub menu (Arabidopsis has this sub menu, not all genomes do) and the three items are randomly ordered. This is likely to annoy anyone who uses any of these items repeatedly, and I think several uses in rapid succession is the most common real use case. Items in the right-click menu should always be listed in the same order. |
User story:
"When I right click an item (Glyph) in a track, a context menu appears. One of the options is "Search Web" If I select "Search Web," a new menu appears (a submenu) with links to sites. The order of the sites shown changes apparently at random as I repeat this action with the same or different items. This is confusing because it doesn't let me learn where to find a particular option. This should be fixed to ensure that menu items always appear in the same location in the menu." To reproduce: * Load an Annotation track (Araport11 from A_thaliana_Jun_2009 genome version) * Right-click on item in the track. * Choose the "web search" option to activate a sub-menu. * Note there are two options: "TAIR" and "Google" * Repeat. Note that "TAIR" and "Google" are listed in a different order from before Task: * Find out why this random sorting is occurring. * Propose a fix here (add a Comment). * Create a new Jira issue (Improvement) for implementing the proposed fix. (Link this issue for instructions on how to do it.) |
| Story Points | 1 | |
| Sprint | Winter 2018 Sprint 3 [ 58 ] | |
| Labels | Beginner Intermediate |
| Attachment | googleFirst.png [ 14210 ] | |
| Attachment | tairFirst.png [ 14211 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Kiran Korey [ kkorey ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Kiran Korey [ kkorey ] |
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Assignee | Nowlan Freese [ nfreese ] |
1st Level Review:
Issue appears fixed. The sites are now ordered in "Search Web". Kiran also noticed that the "Get Info" and "Search Web" menu items were also themselves unordered and would flip randomly. They are now ordered as well.
Needs a fix to the commit, then it should be ready for a pull request.
| Assignee | Nowlan Freese [ nfreese ] | Kiran Korey [ kkorey ] |
| Status | Reviewing [ 10301 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Reviewing [ 10301 ] |
| Rank | Ranked higher |
| Sprint | Winter 2018 Sprint 3 [ 58 ] | Winter 2018 Sprint 3, Spring 2019 Sprint 1 [ 58, 59 ] |
| Rank | Ranked higher |
| Status | Reviewing [ 10301 ] | In Progress [ 3 ] |
Can you take a look at the commit now?
https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1155-context-menu
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Kiran Korey [ kkorey ] |
| Status | Needs 1st Level Review [ 10005 ] | Reviewing [ 10301 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Commit looks good, moving to ready for pull request.
| Status | Reviewing [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Nowlan Freese [ nfreese ] | Kiran Korey [ kkorey ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Kiran Korey [ kkorey ] |
Merged to master.
| Status | Pull Request Submitted [ 10101 ] | Needs Testing [ 10002 ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
Testing Mac: Working Correctly
Note: In the right click menu, the Get Info and Google menu options are unordered. This was not part of this issue, but would be related. A new issue has been raised IGBF-1540.
Testing Windows: Working Correctly
Note: In the right click menu, the Get Info and Google menu options are not ordered. This was not part of this issue, but would be related. This issue raised has been raised: IGBF-1540
Testing Linux: Working Correctly
Note: In the right click menu, the Get Info and Google menu options are unordered. This was not part of this issue, but would be related. A new issue has been raised IGBF-1540.
| Resolution | Done [ 10000 ] | |
| Status | Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Kiran Korey [ kkorey ] |
| Workflow | Loraine Lab Workflow [ 17797 ] | Fall 2019 Workflow Update [ 19802 ] |
| Workflow | Fall 2019 Workflow Update [ 19802 ] | Revised Fall 2019 Workflow Update [ 21921 ] |
The random sorting was due to the use of SET, which is an unordered collection.
Changing to different collection affects a lot of places.
So, sorting based on the label of the menu item is performed, before adding to the Jmenu.
Need a first level review for this branch.
https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1155-context-menu
Thanks.