Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1244

App Manager can't install apps

        Details

        • Sprint:
          B - Summer 2018

          Description

          I uninstalled IGB from my machine and cleared preferences.

          I installed a fresh copy of 9.0.1.

          The apps would not install.

          Then I installed 9.0.0, and checked to make sure that I could install the apps, and they installed. I closed 9.0.0.

          I closed and re-opened IGB 9.0.1. Now I can install the apps in IGB 9.0.1.

          It looks like the apps are accessible to 9.0.0 but not to 9.0.1, but once accessed by 9.0.0, they become available to 9.0.1.
          "access" may not be the best verb here... I mean they are installable and un-installable.

          I cleared my IGB preferences.

          Now in 9.0.1, the apps that were installed are still installed, and cannot be uninstalled. The apps that were not installed are not installed, and cannot be installed.

          To verify this a little further, I cleared preferences, opened 9.0.0, installed some apps, closed 9.0.0, opened 9.0.1. Now 9.0.1 can install/uninstalled apps.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1256 Investigate UI zooming on high resolution (4K) screen

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                7 older comments
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                ICB comment:

                "Good find. I checked out the previous commit for each of those two files (leaving everything else on current commit).

                Clear bundles, clean & build, run, open app manager ... IGB 9.0.1 is able to install the apps via the app manager."

                Show
                ann.loraine Ann Loraine added a comment - - edited ICB comment: "Good find. I checked out the previous commit for each of those two files (leaving everything else on current commit). Clear bundles, clean & build, run, open app manager ... IGB 9.0.1 is able to install the apps via the app manager."
                Hide
                Permalink
                ieclabau Ivory Blakley (Inactive) added a comment - - edited

                Git commands:

                get up to date commits
                $ git pull upstream master

                make a new branch
                $ git checkout -b AppManagerRevertTest

                Look at the history of the those files
                $ git log plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/repos/view/AddBundleRepositoryFrame.java

                See that this commit is the commit just before the change.
                b845609bc1c09797a637a59e24896ed8c861171e

                checkout that commit for both of the changed files
                $ git checkout b845609bc1c09797a637a59e24896ed8c861171e plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/repos/view/AddBundleRepositoryFrame.java
                $ git checkout b845609bc1c09797a637a59e24896ed8c861171e plugins/plugin-manager/pom.xml

                push this branch
                $ git push --set-upstream origin AppManagerRevertTest

                Branch is on bitbucket at:
                https://bitbucket.org/IvoryBlak/integrated-genome-browser/branch/IGBF-1244_AppManagerRevertTest
                (I changed the branch name to include the issue id)

                Show
                ieclabau Ivory Blakley (Inactive) added a comment - - edited Git commands: get up to date commits $ git pull upstream master make a new branch $ git checkout -b AppManagerRevertTest Look at the history of the those files $ git log plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/repos/view/AddBundleRepositoryFrame.java See that this commit is the commit just before the change. b845609bc1c09797a637a59e24896ed8c861171e checkout that commit for both of the changed files $ git checkout b845609bc1c09797a637a59e24896ed8c861171e plugins/plugin-manager/src/main/java/org/lorainelab/igb/plugin/manager/repos/view/AddBundleRepositoryFrame.java $ git checkout b845609bc1c09797a637a59e24896ed8c861171e plugins/plugin-manager/pom.xml push this branch $ git push --set-upstream origin AppManagerRevertTest Branch is on bitbucket at: https://bitbucket.org/IvoryBlak/integrated-genome-browser/branch/IGBF-1244_AppManagerRevertTest (I changed the branch name to include the issue id)
                Hide
                Permalink
                ieclabau Ivory Blakley (Inactive) added a comment -

                That ran into build issues...
                Try again, but this time revert the java file all the way back to this commit:
                0b1ac564f0a2f03c8dda5863e55fdf0857442b96

                Build success!
                But I ran the installer and the bug persists. Poop.

                Kiran showed me that the app manager DOES work in 9.0.1 some portion of the time.
                On my computer I cleared preferences and then opened 9.0.1, opened app manager and repeated this cycle many times.
                The app manager did not work in the first 3 times, on the 4th time it worked fine. On the 5th time, it worked for about a minute, then stopped working. On the 6th time it did not work.

                If 9.0.1 does work some random fraction of the time, then that might explain why it seemed to be working fine in my test on Friday even though the changes did not fix anything.

                I saved the preferences file during the working/ not working and stopped-working moments to see if some state was preserved there, but the three copies are identical.

                Ann thinks this issue may relate to an incompatibility between swing event loop and the javaFX event loop.
                Or possibly a java version issue.

                Show
                ieclabau Ivory Blakley (Inactive) added a comment - That ran into build issues... Try again, but this time revert the java file all the way back to this commit: 0b1ac564f0a2f03c8dda5863e55fdf0857442b96 Build success! But I ran the installer and the bug persists. Poop. Kiran showed me that the app manager DOES work in 9.0.1 some portion of the time. On my computer I cleared preferences and then opened 9.0.1, opened app manager and repeated this cycle many times. The app manager did not work in the first 3 times, on the 4th time it worked fine. On the 5th time, it worked for about a minute, then stopped working. On the 6th time it did not work. If 9.0.1 does work some random fraction of the time, then that might explain why it seemed to be working fine in my test on Friday even though the changes did not fix anything. I saved the preferences file during the working/ not working and stopped-working moments to see if some state was preserved there, but the three copies are identical. Ann thinks this issue may relate to an incompatibility between swing event loop and the javaFX event loop. Or possibly a java version issue.
                Hide
                Permalink
                kkorey Kiran Korey (Inactive) added a comment -

                The fix for the issue is in the branch :
                https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1244-AppManager

                A reference link which speaks about the problem and solution:
                https://stackoverflow.com/questions/41903154/javafx-webview-callback-from-javascript-failing-after-garbage-collection

                Show
                kkorey Kiran Korey (Inactive) added a comment - The fix for the issue is in the branch : https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1244-AppManager A reference link which speaks about the problem and solution: https://stackoverflow.com/questions/41903154/javafx-webview-callback-from-javascript-failing-after-garbage-collection
                Hide
                Permalink
                kkorey Kiran Korey (Inactive) added a comment -

                Need a review for the branch

                https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1244-AppManager

                Thanks

                Show
                kkorey Kiran Korey (Inactive) added a comment - Need a review for the branch https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1244-AppManager Thanks

                  People

                  • Assignee:
                    kkorey Kiran Korey (Inactive)
                    Reporter:
                    ieclabau Ivory Blakley (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: