Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.0.2 Minor Release
-
Labels:
-
Story Points:2
-
Sprint:B - Summer 2018, Summer 2018 Part 2, Summer 2018 Part 3, Fall 2018 1, Fall 2018 Sprint 2
Description
IGB scripting language contains command:
snapshotmainView
which accepts a file path and name as a parameter.
Improve the command syntax:
- Enable Unix-style relative paths, e.g.:
~/foo.png # user's home directory
./foo.png # saved in current working directory
../foo.png # saved in parent directory
foo.png # saved in current working directory
- Detect the OS and handle OS-specific file path designations gracefully
For example, on Windows, users should be able to use back-slashes in file paths
- Develop test scripts for each platform testing supported ways a user may indicate file name and path
The testing procedure is in the following link:
https://wiki.transvar.org/display/ITD/Command+Socket+Plugin
/* Problems faced during testing on windows: Sneha */
To run bash script on windows, we need to follow the instructions in the site below to configure Windows machine.
https://www.lifewire.com/how-to-run-the-bash-command-line-in-windows-10-4072207
After configuring Windows to run bash script,
Change the first line in the Example script found in Test page (CommandSocketExample.sh)
#Unable to render embedded object: File (/bin/sh -----> #) not found./bin/bash
Use https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1286-tilde installer for testing!
Attachments
Issue Links
Activity
Also I have an input on this. If the folder doesn't exist in the system to store images, then how about changing the script to create folder.?
Because currently, User is misled with the information that his images are saving but console error says that the folder is not found!
Ivory Blakley : Did you face the "Access Denied" issue in mac while saving images in current and parent directory?
Done with testing on Windows. Few features aren't working due to Permission issues.
Assigning it to Kiran Korey to cross verify in his machine. Moving it to "To-do" column.
After talking to [~aloraine]
Showing Acces denied if using dot or dot-dot is expected behavior in windows systems and is absolutely fine.
I have created issue IGBF-1384 to handle file not found exception to create a folder if it does not exist.
So moving to Ready for pull Request column.
Using main master, and the script down in the Command socket app readme,
and I modified the script to save to '~/Downloads/'$
'.png'.
Both worked, I think all looks good here.
I tested this on mac.
I never encountered a permission issue. I assume 
it has to do with the fact that my user has permission to make changes in the folder where I installed IGB.
I am reassigning this to Kiran so records show that he tackled the issue, and I am marking it as done.
After making changes below relative paths are supported in both Windows and Linux:
./foo.png # saved in the current working directory
../foo.png # saved in parent directory
foo.png # saved in the current working directory
However, Because the home character is not supported by windows,
~/foo.png # user's home directory - This works only in Linux.
Should I explicitly handle '~' char for windows system and replace it with users home directory programmatically?
Please review the code in the following branch,
https://bitbucket.org/kkorey/kkorey-igb/branch/IGBF-1286-Rel-path-snapshot