Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 9.1.10 Major Release
-
Labels:
-
Story Points:2
-
Epic Link:
Description
Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. It overwrites the file myFile.bed.bed file.
If I then save a file with the name "myfile.bed.bed" and I select the ".bed" extension, it asks if I want to replace the file. If I say yes, it write a new file called myFile.bed.bed.bed (leaving the myFile.bed.bed in place).
This seems very closely related to issue IGBF-1128.
The system should check if the file already exists and prompt the user to confirm that an existing file should be replaced. It does this. But it adds the file extension AFTER it does this check. It should add the file extension first, then check if that file name already exists.
We should also add a check to see if the given name already ends in the desired file extension.
To see the Save Track As... option, right click on a track label.
This is true for both annotation tracks and graph tracks.
I think this is a beginner issue, but I say that without having looked at the code, it might be more complicated.
Attachments
Issue Links
Activity
Assignee | Ann Loraine [ aloraine ] |
Description |
Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. This seems very closely related to issue |
Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. It overwrites the file myFile.bed.bed file. If I then save a file with the name "myfile.bed.bed" and I select the ".bed" extension, it asks if I want to replace the file. If I say yes, it write a new file called myFile.bed.bed.bed (leaving the myFile.bed.bed in place). This seems very closely related to issue The system should check if the file already exists and prompt the user to confirm that an existing file should be replaced. It does this. But it adds the file extension AFTER it does this check. It should add the file extension first, then check if that file name already exists. We should also add a check to see if the given name already ends in the desired file extension. To see the Save Track As... option, right click on a track label. I think this is a beginner issue, but I say that without having looked at the code, it might be more complicated. |
Summary | File extension is added even if it is already present | Check if file is present AFTER adding the file extension, only add extension if it is not already there |
Labels | Beginner |
Description |
Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. It overwrites the file myFile.bed.bed file. If I then save a file with the name "myfile.bed.bed" and I select the ".bed" extension, it asks if I want to replace the file. If I say yes, it write a new file called myFile.bed.bed.bed (leaving the myFile.bed.bed in place). This seems very closely related to issue The system should check if the file already exists and prompt the user to confirm that an existing file should be replaced. It does this. But it adds the file extension AFTER it does this check. It should add the file extension first, then check if that file name already exists. We should also add a check to see if the given name already ends in the desired file extension. To see the Save Track As... option, right click on a track label. I think this is a beginner issue, but I say that without having looked at the code, it might be more complicated. |
Save track As… allows me to overwrite a file without a pop-up asking if that is ok. According to the test module, saving a file under an existing file name (replacing a file) should result in a confirmation pop-up.
If I choose to save a file as “myfile.bed” and I select the “.bed” extension, the system checks to see if there a file called “myfile.bed” and then it saves a file called “myFile.bed.bed”. If I save it the same way multiple times (“myfile.bed” and I select the “.bed” extension) then it never prompts me to confirm that I want to replace the file. It overwrites the file myFile.bed.bed file. If I then save a file with the name "myfile.bed.bed" and I select the ".bed" extension, it asks if I want to replace the file. If I say yes, it write a new file called myFile.bed.bed.bed (leaving the myFile.bed.bed in place). This seems very closely related to issue The system should check if the file already exists and prompt the user to confirm that an existing file should be replaced. It does this. But it adds the file extension AFTER it does this check. It should add the file extension first, then check if that file name already exists. We should also add a check to see if the given name already ends in the desired file extension. To see the Save Track As... option, right click on a track label. This is true for both annotation tracks and graph tracks. I think this is a beginner issue, but I say that without having looked at the code, it might be more complicated. |
Labels | Beginner | intermediate |
Workflow | Loraine Lab Workflow [ 18115 ] | Fall 2019 Workflow Update [ 18907 ] |
Workflow | Fall 2019 Workflow Update [ 18907 ] | Revised Fall 2019 Workflow Update [ 21034 ] |
Status | Open [ 1 ] | To-Do [ 10305 ] |
Epic Link | IGBF-1765 [ 17855 ] |
Summary | Check if file is present AFTER adding the file extension, only add extension if it is not already there | Improve file name and file existence checking logic when saving track data |
Rank | Ranked higher |
Story Points | 2 |
Rank | Ranked higher |
Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Resolution | Done [ 10000 ] | |
Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Fix Version/s | 9.1.10 Major Release [ 10700 ] |
Assignee | Nowlan Freese [ nfreese ] |
This ticket was completed as part of
IGBF-2654