Test App Store workflow

I am currently trying out the new App Store and I noticed the following issues/suggestions:
1. I tried installing apps after downloading them from bitbucket. They were not working in the app-store as some dependencies were missing. I expected that since the apps are developed specifically for IGB, the jar should work without any further modification. This observation is valid only for 23andme and ProtAnnot app. (Command Socket, Merge Annotation and Geometric mean operator worked seamlessly.)

2. After I selected the app in the file chooser, I was seeing the information about OSGi bundles. After I submitted the app, the validation steps were performed on the jar. It would have been nicer if the information about OSGi bundles was shown upfront and the validation checks were performed right after the jar selection and before the user hit the submit button. This will also prevent the developer from submitting the app multiple times.

3. After I submitted ProtAnnot app, I received a mail about pending app approval. However, the app was uploaded in the S3 bucket but with a different name than expected, therefore the app was not installing.
(This could be happening because the app name and presentation name of ProtAnnot were different. We need to fix this and consider only one name while generating the repository.xml if that is the case.)

3a. Enhancement suggestion: The Email subject is generic: "IGB App Store - Submission Done!". We could make it more informative by adding the name of the submitted app in the email, something like this: "IGB App Store - ProtAnnot Submission Done!"

4. After I approved the app as admin, I received the approval mail. However the link in the mail http://testappstore.bioviz.org:443/apps/protannot is Http and not Https, so it did not work.
Also, the link looks odd with the 443 port included in the Http link.

5. In editing options of the app, I was unable to add more email addresses of editors. Got the error saying "Email is invalid.". I was also not able to close the "add email" pop-up.

6. After submit app, confirm submission page is displayed. But as per present behavior, the initial submit button triggers the email and goes ahead and submits the app, without waiting for developer confirmation/cancellation. This needs to be fixed.

7. While editing the rating of the app, it opens a pop-up saying "Thank you for your input, the rating has been updated." After showing the message the pop-up should get automatically closed. If the user clicks on the ratings multiple times, multiple popups are displayed and main content of the page shifts down and is inaccessible after one point as there is no right scrollbar in the page.

8. I closed IGB to verify if I was getting alert "IGB is not running". I got the alert, but I continued to get that alert even after IGB was running again.

9. After adding details to the app like website, tutorial, and code repository, email, it is not displaying correctly on the view app page.

10. Currently if we click on screenshots they get opened in a new window. I suggest they should open as a pop-up on the same page and should rotate with left and right arrow button. On escape the image popup should get closed.

4. Fixed > IGBF-1890
5. Correct Behaviour as the Editor needs to be a Registered User
6. Fixed > IGBF-1888
7. Fixed > IGBF-1887
8. Not Able to reproduce. It would be great if I had some steps to reproduce.
9. Fixed > IGBF-1885
10. Image Popover Gallery Implemented > IGBF-1891

Hi Sameer Shanbhag,

Please mark the above jiras raised by you as "related" to this ticket.

Also, regarding above issues
5. The "email is invalid" message is still misleading as I understand it as - the format of email is wrong. It can be something more informative, something like - "Editor email should be a registered user". Also the popup of "add email" does not close after an "invalid" email is entered.
8. Steps to reproduce:
a. Close IGB. Go to https://testappstore.bioviz.org and click on an app.
b. Start IGB
c. Refresh the website. It still shows the message "IGB is not running".

Hi Srishti Tiwari,

I'm still not able to reproduce the issue. Added the steps I'm currently doing to this thread.

1. I checked this issue on Charan's and Pawan's machine. The version of IGB needs to be latest. Also the "IGB not running" feature is only running on Chrome, not on Firefox and Internet Explorer.
2. Also, on Internet Explorer the css seems to be broken. Refer screenshot.

Some notes about "IGB Not Running"

1. When IGB Desktop Application is running it opens up a local endpoint which points to http://127.0.0.1:7090/manageApp
2. App store tries to hit that endpoint [A POST Request] as shown in the Screenshot.
3. It App store receives a 200 Response from the Endpoint, it removes the "IGB Not Running" Popover and displays the Install Options.

Problem Associated with this:
1. Some browsers are strict with their CORS Policies [Cross-Origin Requests] and Block the Request even before its made. [Browsers like FireFox | Attached a screenshot]

Solution:
1. We need to find a way to allow Cross-Origin Request, that can be done by setting Allow Cross-Origin Headers in Request and Response.

I hope this helps.

Another observation:
Bundle description is mandatory for submitting an app to the AppStore.(It is breaking submission of hello world app for this reason.) This information is not written in the information provided to developers on osgi bundles (before app submission). Also, if the bundle description is missing, the website breaks. We can do an exception handling in this case.

Yes, I think this is a good suggestion. We can allow an App to lack a description without breaking the upload/submit an App process. We also need to provide good documentation regarding what can or should be included in the jar MANIFEST.

I was able to upload a new version of Geometric mean App without needing to get it approved, but the email received after the app submission said it will need approval. We will need to add a check to see whether it is a new app or an updated app, and will need to change the content of the email.

Not closing this issue as the related Jiras need to be fixed and this workflow needs to be tested one more time.

Yes, thank you!

Most of the Related JIRA's are merged on the Testappstore.
Can be moved back to Testing.

Testing can be done at : https://testappstore.bioviz.org/

Shamika Gajanan Kulkarni

Please work on this after you've moved IGBF-2012 and IGBF-2015 into "Needs first level review"

Let me know if you have any questions/concerns.

Deployed the latest master branch on https://dev-appstore-2.bioviz.org.
Add this URL as an App repository in IGB: https://dev-appstore-2.bioviz.org/obr/releases/

Yes will work on it. Thank you.

Un-assigning since Shamika Gajanan Kulkarni is working on a different issue currently.

Tested the App store workflow using Super Simple IGB App and Get Average Score App by following the guidelines mentioned in the description. I have the following observations to report. I am not sure if they have been handled or not, but would like to bring them into notice.
1) On clicking "All Apps", the pagination does not display a number.
2) When an app is in the pending apps repo, and a new version a.b.c is submitted by the developer, the information for "Is this a new App" displays a message saying "Currently, the highest version released in App Store is a.b.c". The app hasn't yet been released, and the highest version as per the message is the one the developer is trying to submit but hasn't submitted yet. I was wondering if we could make the information display a message that can be more clearer rather than ambiguous.
3) When a developer submits a new version of an already released App, he/she is redirected to a page to edit the App page. Without making any changes, the save button is not activated. So, I was not sure while doing it for the first time, whether clicking on Cancel would terminate the process to release a new version or would it just cancel any changes to the edit App page. If we could display a message or activate Save button, I think it should help.
Kindly review these points. Thank you.

Shamika Gajanan Kulkarni - great feedback. Thanks!