Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 2019 Sprint 3
Description
Modify the "Submit" App page to more closely match what is shown in design document (see link in IGBF-1955).
Make following changes to the page:
1) Always show the green "next" button. It should always be displayed and active. If a user clicks the "next" button before uploading a file or entering a URL, show a message that reads "Please upload a file or enter a URL."
2) Don't show the OSGi-related text that currently appears when a user uploads a file or enters a URL. Delete it from the code. We are going to provide this info via a link to developer documentation.
3) Remove any logic that inactivates components (trash cans, buttons, etc) based on the state of other components.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Assignee | Sameer Shanbhag [ sameer ] |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
I discussed with Riddhi Jagdish Patil and we think that the trash can should function as it is and should activate only when there is content in the Input Box and not otherwise.
Prof. [~aloraine]: Please let me know if we should necessarily implement removal of that logic. If it is not required i can raise a pull request for the other two changes.
OK
Merged to master in lorainelab/appstore.
To facilitate testing, Sameer Shanbhag or Riddhi Jagdish Patil please deploy on a dev-appstore instance of your choice.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Sameer Shanbhag [ sameer ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Sameer Shanbhag [ sameer ] |
Pushed on dev-appstore-1, Screenshot attached.
Working as expected. Moving it to Done.
| Resolution | Done [ 10000 ] | |
| Attachment | Snip-NextButton.png [ 14417 ] |
Update: (Not Related to this Ticket)
1. Trash Icon Not Working for Enter URL Field.
2. If you try to submit malformed URL it throws Internal Server Error rather than handling the error.
To reproduce #2 Enter the following url:
https://bitbucket/lorainelab/merge-annotation-operator/downloads/merge-annotation-operator-9.1.0.jar
Created a Ticket : IGBF-2025
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Workflow | Fall 2019 Workflow Update [ 20771 ] | Revised Fall 2019 Workflow Update [ 22513 ] |
Changes #1 and #2 Completed and can be reviewed at:
https://bitbucket.org/sshanbh1/sameer-appstorefork/commits/eec6cf57976bfc7e8fb69d35de43e73a0f601343
Working on Change #3