Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2014

Remove hidden text from Submit App page

        Details

        • Type: Improvement
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Modify the "Submit" App page to more closely match what is shown in design document (see link in IGBF-1955).

          Make following changes to the page:

          1) Always show the green "next" button. It should always be displayed and active. If a user clicks the "next" button before uploading a file or entering a URL, show a message that reads "Please upload a file or enter a URL."

          2) Don't show the OSGi-related text that currently appears when a user uploads a file or enters a URL. Delete it from the code. We are going to provide this info via a link to developer documentation.

          3) Remove any logic that inactivates components (trash cans, buttons, etc) based on the state of other components.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-2025 Handle Malformed URL on Submit App Page

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. IGBF-1955 Improve Submit App pages

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Changes #1 and #2 Completed and can be reviewed at:
                https://bitbucket.org/sshanbh1/sameer-appstorefork/commits/eec6cf57976bfc7e8fb69d35de43e73a0f601343

                Working on Change #3

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Changes #1 and #2 Completed and can be reviewed at: https://bitbucket.org/sshanbh1/sameer-appstorefork/commits/eec6cf57976bfc7e8fb69d35de43e73a0f601343 Working on Change #3
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                I discussed with Riddhi Jagdish Patil and we think that the trash can should function as it is and should activate only when there is content in the Input Box and not otherwise.

                Prof. [~aloraine]: Please let me know if we should necessarily implement removal of that logic. If it is not required i can raise a pull request for the other two changes.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - I discussed with Riddhi Jagdish Patil and we think that the trash can should function as it is and should activate only when there is content in the Input Box and not otherwise. Prof. [~aloraine] : Please let me know if we should necessarily implement removal of that logic. If it is not required i can raise a pull request for the other two changes.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                OK

                Show
                ann.loraine Ann Loraine added a comment - OK
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged to master in lorainelab/appstore.
                To facilitate testing, Sameer Shanbhag or Riddhi Jagdish Patil please deploy on a dev-appstore instance of your choice.

                Show
                ann.loraine Ann Loraine added a comment - Merged to master in lorainelab/appstore. To facilitate testing, Sameer Shanbhag or Riddhi Jagdish Patil please deploy on a dev-appstore instance of your choice.
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Pushed on dev-appstore-1, Screenshot attached.

                Working as expected. Moving it to Done.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Pushed on dev-appstore-1, Screenshot attached. Working as expected. Moving it to Done.
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment - - edited

                Update: (Not Related to this Ticket)

                1. Trash Icon Not Working for Enter URL Field.
                2. If you try to submit malformed URL it throws Internal Server Error rather than handling the error.

                To reproduce #2 Enter the following url:
                https://bitbucket/lorainelab/merge-annotation-operator/downloads/merge-annotation-operator-9.1.0.jar

                Created a Ticket : IGBF-2025

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - - edited Update: (Not Related to this Ticket) 1. Trash Icon Not Working for Enter URL Field. 2. If you try to submit malformed URL it throws Internal Server Error rather than handling the error. To reproduce #2 Enter the following url: https://bitbucket/lorainelab/merge-annotation-operator/downloads/merge-annotation-operator-9.1.0.jar Created a Ticket : IGBF-2025

                  People

                  • Assignee:
                    sameer Sameer Shanbhag (Inactive)
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: