Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2016

Store and serve App logo files in App version directory in release directory

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Currently, App logo files uploaded by users are getting saved in the top level of the "media" directory in S3. Also, these files are named after whatever the user uploaded, with an added ".png" extension.

      This is problematic because it makes the S3 bucket file and folder organization very hard to understand and manage. Also, it's a bit weird that we automatically add the ".png" extension. It's not clear what will happen if the file is not actually in png format.

      Let's make our infrastructure more rationale as follows:

      • When a user uploads a logo file for a given version of an App, the logo file will be stored in the version subdirectory for that App.
      • Also, the logo file will be named after the App Bundle-Symbolic name and version.

      For example:

      User uploads a logo file named "goofy_Weird_strange_and_ bizarre name for a file.JPG" for an App with Bundle-SymbolicName "goofy-app" and Bundle-Version "0.0.1"

      The App Store will allow this file to be uploaded but will re-name it goofy-app-0.0.1.jpg.

      *Note*: We transform the file extension to lower-case letters and we keep whatever file extension the user assigned, assuming the file format is not actually getting changed to "png" in our code. (PNG is a different file format from JPEG, which is lossy and is typically used only for photographs and not computer-generated graphic art such as logo images.)

        Attachments

          Activity

          Hide
          aloraine Ann Loraine added a comment -

          Would you work on this one next time you are in Kannapolis?
          Let me know if you have any questions/concerns or need anything!

          Show
          aloraine Ann Loraine added a comment - Would you work on this one next time you are in Kannapolis? Let me know if you have any questions/concerns or need anything!
          Hide
          aloraine Ann Loraine added a comment -

          Un-assigning (for now) because Noor Zahara may need to take the rest of the week to focus on classes and other things.

          Show
          aloraine Ann Loraine added a comment - Un-assigning (for now) because Noor Zahara may need to take the rest of the week to focus on classes and other things.
          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Pull Request Submitted for this change: https://bitbucket.org/lorainelab/appstore/pull-requests/116/igbf-2016-change-thumbnail-and-screenshot/diff
          Hide
          aloraine Ann Loraine added a comment -

          Merged to master branch.

          Sameer Shanbhag please deploy to your dev appstore instance for testing.

          Show
          aloraine Ann Loraine added a comment - Merged to master branch. Sameer Shanbhag please deploy to your dev appstore instance for testing.
          Hide
          aloraine Ann Loraine added a comment -

          Change requests:

          • Do not prefix the file name with "logo_"
          • Do not store the file in a "logo" subdirectory. Instead, store it in the release directory.

          For example:

          If I upload a file named "1545938680.png" as the new logo for super-simple-igb-app (Bundle-SymbolicName) version 0.0.1 (Bundle-Version), then the file should be stored as follows in S3:

          /media/super-simple-igb-app/releases/0.0.1/super-simple-igb-app-0.0.1.png

          not as

          /media/super-simple-igb-app/releases/0.0.1/logo/logo_super-simple-igb-app-0.0.1.png

          Show
          aloraine Ann Loraine added a comment - Change requests: Do not prefix the file name with "logo_" Do not store the file in a "logo" subdirectory. Instead, store it in the release directory. For example: If I upload a file named "1545938680.png" as the new logo for super-simple-igb-app (Bundle-SymbolicName) version 0.0.1 (Bundle-Version), then the file should be stored as follows in S3: /media/super-simple-igb-app/releases/0.0.1/super-simple-igb-app-0.0.1.png not as /media/super-simple-igb-app/releases/0.0.1/logo/logo_super-simple-igb-app-0.0.1.png
          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Pull Request Submitted : https://bitbucket.org/lorainelab/appstore/pull-requests/118/igbf-2016-change-logo-location/diff
          Hide
          aloraine Ann Loraine added a comment -

          Merged but not yet deployed to dev-appstore-2.bioviz.org (App Store master branch)

          Show
          aloraine Ann Loraine added a comment - Merged but not yet deployed to dev-appstore-2.bioviz.org (App Store master branch)
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          Working as Expected. Screenshot Attached. Moving it to done.

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Working as Expected. Screenshot Attached. Moving it to done.

            People

            • Assignee:
              sameer Sameer Shanbhag (Inactive)
              Reporter:
              aloraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: