Issue:
Pending app of different versions is not able to be released

Solution:
Instead of creating new object whenever accepting request from pending, check if the object with same App already exists in Database, if yes, update the version and release path of that object else create new one.

Files changed:
Code changes are present in branch IGBF-2050
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2050
submit_app/models.py
submit_app/views.py

Testing steps:
1) Click on Submit Your App -> Upload an app with some version. for eg - super-simple-igb-app-0.0.1.jar
2) Click on Submit Your App -> Upload same app with different version. for eg - super-simple-igb-app-0.0.3.jar
3) Login as admin
4) Go to Pending apps
5) Accept pending request for super-simple-igb-app-0.0.1 app
6) Accept pending request for super-simple-igb-app-0.0.3 app
Both the apps should be accepted
Check the behavior by logging to the admin page
1) Only one app with Bundle_SymbolicName super-simple-igb-app should be present and its version and release file should be 0.0.3
2) Releases tab should have two entries - one for release 0.0.1 and another for release 0.0.3

Code changes deployed to https://dev-appstore-6.bioviz.org
cc.[~aloraine]

Need a repository for testing. Creating this now.

Repository is created. See details in https://jira.transvar.org/browse/IGBF-2062

My apologies! I forgot you are working on fixing the "name" issue as noted on the branch.
Moving to "In Progress."

Issue:
1. Pending app of different versions is not able to be released.
2. To remove "name attribute from the database"

Solution:
1. Instead of creating new object whenever accepting request from pending, check if the object with same App already exists in Database, if yes, update the version and release path of that object else create new one.
2. Remove reference of "name" variable from the code and replace it with "Bundle_SymbolicName"

Files changed:
Code changes are present in branch IGBF_2050
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF_2050#diff
apps/models.py
apps/search_indexes.py
apps/templates/app_page.html
download/templates/app_stats.html
submit_app/models.py
submit_app/parseRepositoryXML.py
submit_app/views.py
templates/search/indexes/apps/app_text.txt

Testing steps:
1) Click on Submit Your App -> Upload an app with some version. for eg - super-simple-igb-app-0.0.1.jar
2) Click on Submit Your App -> Upload same app with different version. for eg - super-simple-igb-app-0.0.3.jar
3) Login as admin
4) Go to Pending apps
5) Accept pending request for super-simple-igb-app-0.0.1 app
6) Accept pending request for super-simple-igb-app-0.0.3 app
Both the apps should be accepted
Check the behavior by logging to the admin page
1) Only one app with Bundle_SymbolicName super-simple-igb-app should be present and its version and release file should be 0.0.3
2) Releases tab should have two entries - one for release 0.0.1 and another for release 0.0.3

NOTE: End-to-end testing required for the AppStore to ensure removal of "name" attribute has not impacted the system.

Code changes deployed to https://dev-appstore-6.bioviz.org. Admin password and username for devappstore-6 is same as devappstore-2

cc.Ann Loraine

I am not sure if it is working as expected.

I logged in as admin after uploading three different versions of the same App, clicked "Accept" on the middle version one, and observed a continuously rotating spinner.

My steps:

1) Logged in as ordinary user (aloraine@uncc.edu)

2) Used App Store UI to submit 3 different versions of the same App:

• https://bitbucket.org/lorainelab/for-testing-app-store-workflow/downloads/for-testing-app-submission-workflow-1.0.0.jar
• https://bitbucket.org/lorainelab/for-testing-app-store-workflow/downloads/for-testing-app-submission-workflow-2.0.0.jar
• https://bitbucket.org/lorainelab/for-testing-app-store-workflow/downloads/for-testing-app-submission-workflow-3.0.0.jar

(I unpacked the jars and checked that the MANIFEST showed the versions indicated above.)

3) Logged in as superuser.
4) Clicked "Release" on version 2.0.0 of the App.
5) Observed that the jar file was still present in S3 bucket for this app store.

Riddhi Jagdish Patil

I forgot to delete tables from devappstore6 database. I deleted the database tables and restarted the ec2 machine.
Please check the ticket now. Sorry for the inconvenience caused.

Known issue:
If multiple versions of the same app are released, deleting one version from the "Edit this App" panel does not delete the App from S3 bucket. Also, deletion of this app from the admin panel does not delete the releases folder from S3 bucket.
This issue will be fixed in ticket IGBF-2072

Can you send the superuser name and password (via email) for testing? (You might also need to use manage.py to re-create the superuser after deleting the database tables. Also please remove any jars that may be there in S3 bucket pending apps.)

Riddhi Jagdish Patil

the username and password is same as devappstore2. I am able to login as admin. Superuser is created in devappstore6. Emailed you credentials for devappstore6.
Cleared database apps and s3 bucket.

I was able to upload 3 versions of the same App at once and then accept them after logging in as an administrative user.
One possibly weird thing was just that the Releases page for the App listed the releases in chronologically order of submissions date/time rather than ordered by version. At some point we might want to change this as it would seem a bit more logical and orderly to users. However this change would be out of scope for this ticket, which passes functional testing.
Please submit PR when ready.

Pull request submitted:
https://bitbucket.org/lorainelab/appstore/pull-requests/139/igbf-2050/diff

Merged but not yet deployed to https://dev-appstore-2.bioviz.org

Testing Results -

1. Apps with different versions are getting accepted via admin login.
2. Release File name and hexchecksum fields are not getting updated.
3. The Release time in releases tab is not getting updated properly.

Testing result issue 2 and 3 will be fixed in the ticket IGBF-2072.
This ticket can be tested again once IGBF-2072 is fixed and merged.
cc. [~aloraine], Noor Zahara

Deployed on https://dev-appstore-2.bioviz.org and ready for testing.

It is working as expected.