Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec
Attachments
Issue Links
Activity
Shamika Gajanan Kulkarni This has been sitting in the testing queue assigned to yourself for about a week. Please indicate the status - does it work and can you now close it?
Prof [~aloraine] I have successfully tested the first scenario mentioned above. Today I started on the second and will update the status tomorrow as the scheduler will run at midnight. I should be able to close it then.
This ticket has been tested and I had observed that the jar for the app without submitter approval got deleted when the scheduler runs. I just want to make sure that it was done by the scheduler itself and not someone else who was working on Testing the Appstore tickets. Just to be sure I am testing this once again today. Hope it's okay.
Successfully tested the ticket. Observed the following:
1) For the settings made recently, the scheduler runs every 2 hours [odd hours of the day like 13:00, 15:00, etc.] and the offset value is set to 1 hour.
2) The entry for app with submitter_approved value as false in AppPending table is deleted if the app was uploaded before one hour time span. The jar is also deleted from S3 pending_releases. [Get Average Score was used to test this]
3) When I tried to submit an app and returned to home page without clicking on Submit, an entry for the app was created in AppPending table with submitter_approved value as false. When I try to resubmit the same app and follow the entire process, there is only one entry in AppPending Table with submitter_approved value as True and the jar is replaced with the new timestamp in S3 pending_releases. When the scheduler runs, it does not delete this app entry or the jar from S3. [Merge Annotation Operator was used to test this]
4) If an app is uploaded within the one hour time span, and the submitter_approved value is False, it does not get deleted by the scheduler right now as this app entry is not treated as stale entry yet. [Super Simple IGB app was used to test this.]
Working as expected. Kindly refer the screenshots attached. Moving to Closed. Thank you.
Thank you Shamika Gajanan Kulkarni for the very clear & thorough description.
Make sure to update python_packages.txt with any new modules required. See commits for how to use pip freeze to make sure all dependencies are listed.