Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2121

Make cron string for pending app cleaning job configurable

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          1
        • Epic Link:
        • Sprint:
          Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec

          Description

          • To change the time span for deleting a stale app, edit: app_pending_cleanup.py. To make this configuration via settings.py and settings.ini.template
          • To add logging statements to cron job

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-2087 Implement data cleaning mechanism to remove stale entries from AppPending table and S3 bucket

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                6 older comments
                Hide
                Permalink
                rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited

                Code changes to add config comments to file:
                https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2121-Bug

                Settings.ini does not allow addition of comments so added comments to settings.py

                cc.[~aloraine]

                Show
                rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited Code changes to add config comments to file: https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2121-Bug Settings.ini does not allow addition of comments so added comments to settings.py cc. [~aloraine]
                Hide
                Permalink
                rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

                Pull request submitted:
                https://bitbucket.org/lorainelab/appstore/pull-requests/173/igbf-2121-bug/diff

                cc. [~aloraine]

                Show
                rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Pull request submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/173/igbf-2121-bug/diff cc. [~aloraine]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged & deployed to https://dev-appstore-2.bioviz.org and ready for testing.

                Show
                ann.loraine Ann Loraine added a comment - Merged & deployed to https://dev-appstore-2.bioviz.org and ready for testing.
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

                This ticket has been tested and I had observed that app entries within the time span for deleting stale entries do not get deleted and the ones which fall out of the time span got deleted. I just want to make sure that it was done by the scheduler itself and not someone else who was working on testing the Appstore tickets. Just to be sure I am testing this once again today. Hope it's okay.

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - This ticket has been tested and I had observed that app entries within the time span for deleting stale entries do not get deleted and the ones which fall out of the time span got deleted. I just want to make sure that it was done by the scheduler itself and not someone else who was working on testing the Appstore tickets. Just to be sure I am testing this once again today. Hope it's okay.
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

                The ticket has been tested and the observations are as follows:
                1) Stale entries [apps uploaded before 1 hour from cron job running time] and with submitter_approved values as False were deleted from AppPending table and jar was deleted from S3 bucket. [Get Average Score]
                2) The apps with submitter_approved value as false and uploaded within 1 hour time span were not deleted from AppPending table during this run time. The jar still remains in S3 bucket. This will be deleted when the next cron job runs after 2 hours. [Super Simple IGB App]

                Kindly refer the screenshots attached. Moving to closed. Thank you.

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - The ticket has been tested and the observations are as follows: 1) Stale entries [apps uploaded before 1 hour from cron job running time] and with submitter_approved values as False were deleted from AppPending table and jar was deleted from S3 bucket. [Get Average Score] 2) The apps with submitter_approved value as false and uploaded within 1 hour time span were not deleted from AppPending table during this run time. The jar still remains in S3 bucket. This will be deleted when the next cron job runs after 2 hours. [Super Simple IGB App] Kindly refer the screenshots attached. Moving to closed. Thank you.

                  People

                  • Assignee:
                    rpatil14 Riddhi Jagdish Patil (Inactive)
                    Reporter:
                    rpatil14 Riddhi Jagdish Patil (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: