Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2102

Fix information icon functionality for non-quickload data sources

        Details

        • Story Points:
          1
        • Epic Link:
        • Sprint:
          Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec

          Description

          I ran across an bug where, with IGB in a naive state, enabling the UCSC data source of type DAS and clicking its information icon results in the Data Sources table becoming unusable, even after closing the Preferences window and opening it up again - click events do not result in any behavior, and the exception thrown in the console is shown in the screenshot. The same occurs for the UofUtahBioinfCore data source of type DAS2.

          The information window seems to have been developed for quickload data source types, so the info icon should either not be present for other enabled data source types, or support for these data sources should be extended with additional logic.

          Discovered on macOS high sierra.

            Attachments

              Issue Links

              relates to

              Sub-task - The sub-task of the issue IGBF-1507 Develop User Interface for showing Quickload site details

              • Major - Major loss of function.
              • Closed

              Sub-task - The sub-task of the issue IGBF-1508 Implement business logic for showing Quickload site information

              • Major - Major loss of function.
              • Closed

              Story - Created by JIRA Software - do not edit or delete. Issue type for a user story. IGBF-1506 Add feature to show details about Quickload Site in Data Source tab of Preference window

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. REL-12 Verify functionality of the data provider subsystem

              • Major - Major loss of function.
              • Testing Complete

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Great catch Philip Badzuh !

                Show
                ann.loraine Ann Loraine added a comment - Great catch Philip Badzuh !
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Shamika Gajanan Kulkarni and I have a working fix at: https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2102#diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Shamika Gajanan Kulkarni and I have a working fix at: https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2102#diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                This looks great. Please submit PR. We will merge and then test.

                For testing, try to:

                • open a file from desktop
                • open a file from Galaxy (shows up as "local" in the tree view in Available Data Sets)
                Show
                ann.loraine Ann Loraine added a comment - This looks great. Please submit PR. We will merge and then test. For testing, try to: open a file from desktop open a file from Galaxy (shows up as "local" in the tree view in Available Data Sets)
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Please see the PR here: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/754/igbf-2102/diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Please see the PR here: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/754/igbf-2102/diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged and master branch installers are built and available from Downloads and from BioViz early release page.

                Show
                ann.loraine Ann Loraine added a comment - Merged and master branch installers are built and available from Downloads and from BioViz early release page.
                Hide
                Permalink
                prutha Prutha Kulkarni (Inactive) added a comment -

                Tested the fix using the branch installer. It's working fine. Submitting it to DONE.

                Show
                prutha Prutha Kulkarni (Inactive) added a comment - Tested the fix using the branch installer. It's working fine. Submitting it to DONE.

                  People

                  • Assignee:
                    pbadzuh Philip Badzuh (Inactive)
                    Reporter:
                    pbadzuh Philip Badzuh (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: