Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2108

Account for bookmark export cancellation

    Details

    • Story Points:
      1
    • Sprint:
      Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec

      Description

      I noticed that when clicking - in the menu bar - Bookmarks -> Export Bookmarks... -> cancel/esc will result in an exception being thrown in the console. Usability doesn't seem to be negatively affected in any way, so this exception/case simply needs to be handled in the code.

        Attachments

          Issue Links

            Activity

            Hide
            pbadzuh Philip Badzuh added a comment -

            I learned that IGBF-1153 introduced a couple print statements that may or may not be needed anymore. One such print statement was the cause of this issue's error, and I have fixed it here: https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2108#diff

            Please review and advise if the print statements are still necessary or if they should be removed prior to submitting a pull request.

            Show
            pbadzuh Philip Badzuh added a comment - I learned that IGBF-1153 introduced a couple print statements that may or may not be needed anymore. One such print statement was the cause of this issue's error, and I have fixed it here: https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2108#diff Please review and advise if the print statements are still necessary or if they should be removed prior to submitting a pull request.
            Hide
            aloraine Ann Loraine added a comment -

            Thank you for noticing this. I don't think it is needed, so removing it is great. Please submit PR.

            Show
            aloraine Ann Loraine added a comment - Thank you for noticing this. I don't think it is needed, so removing it is great. Please submit PR.
            Show
            pbadzuh Philip Badzuh added a comment - No problem. Please see the pull request here: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/753/igbf-2108-remove-bookmark-export/diff
            Hide
            aloraine Ann Loraine added a comment - - edited

            Merged. Master branch installers built and deployed to bioviz.org early access release location.

            Show
            aloraine Ann Loraine added a comment - - edited Merged. Master branch installers built and deployed to bioviz.org early access release location.
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            Philip Badzuh, I have tested the "Export Bookmark" functionality in the IGB early access version and no exceptions were thrown when I clicked on cancel/esc. Moving the ticket to DONE.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - Philip Badzuh , I have tested the "Export Bookmark" functionality in the IGB early access version and no exceptions were thrown when I clicked on cancel/esc. Moving the ticket to DONE.

              People

              • Assignee:
                pbadzuh Philip Badzuh
                Reporter:
                pbadzuh Philip Badzuh
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: