Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Blocker
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1.5
-
Epic Link:
-
Sprint:Fall 8 : 25 Nov to 6 Dec
Description
Noted in https://jira.transvar.org/browse/REL-40 by Shamika Gajanan Kulkarni:
See REL-40 for screen shot.
"6) After releasing 3.0.0 version of this app which is compatible with IGB 10.0.0 and not with IGB 9.1.0, I could still see an option of installing the app when IGB 9.1.0 was running. After clicking on 'Install this App' the version 2.0.0 which is compatible with IGB 9.1.0 got installed. The button also changed to 'Installed' on Appstore, though a higher version of App was released on Appstore. Basically, on Appstore, it showed Installed even when the higher version was not compatible with IGB 9.1.0 and the higher version was not actually installed."
Loraine comment:
When App Store javascript hits the localhost IGB App Store endpoint, it should check Bundle-Version of the App and ensure that the button displays "Installed" only if that particular version of the App (shown in App Store) is installed.
Attachments
Issue Links
- relates to
-
REL-40 End-to-end testing with App for Testing App Workflow
-
- Fix Requested
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Description |
A
Noted in https://jira.transvar.org/browse/REL-40 by [~shamika]: "6) After releasing 3.0.0 version of this app which is compatible with IGB 10.0.0 and not with IGB 9.1.0, I could still see an option of installing the app when IGB 9.1.0 was running. After clicking on 'Install this App' the version 2.0.0 which is compatible with IGB 9.1.0 got installed. The button also changed to 'Installed' on Appstore, though a higher version of App was released on Appstore. Basically, on Appstore, it showed Installed even when the higher version was not compatible with IGB 9.1.0 and the higher version was not actually installed." When App Store javascript hits the localhost IGB App Store endpoint, it should check Bundle-Version of the App and ensure that the button displays "Installed" only if that particular version of the App (shown in App Store) is installed. |
Noted in https://jira.transvar.org/browse/REL-40 by [~shamika]:
See REL-40 for screen shot. "6) After releasing 3.0.0 version of this app which is compatible with IGB 10.0.0 and not with IGB 9.1.0, I could still see an option of installing the app when IGB 9.1.0 was running. After clicking on 'Install this App' the version 2.0.0 which is compatible with IGB 9.1.0 got installed. The button also changed to 'Installed' on Appstore, though a higher version of App was released on Appstore. Basically, on Appstore, it showed Installed even when the higher version was not compatible with IGB 9.1.0 and the higher version was not actually installed." When App Store javascript hits the localhost IGB App Store endpoint, it should check Bundle-Version of the App and ensure that the button displays "Installed" only if that particular version of the App (shown in App Store) is installed. |
| Description |
Noted in https://jira.transvar.org/browse/REL-40 by [~shamika]:
See REL-40 for screen shot. "6) After releasing 3.0.0 version of this app which is compatible with IGB 10.0.0 and not with IGB 9.1.0, I could still see an option of installing the app when IGB 9.1.0 was running. After clicking on 'Install this App' the version 2.0.0 which is compatible with IGB 9.1.0 got installed. The button also changed to 'Installed' on Appstore, though a higher version of App was released on Appstore. Basically, on Appstore, it showed Installed even when the higher version was not compatible with IGB 9.1.0 and the higher version was not actually installed." When App Store javascript hits the localhost IGB App Store endpoint, it should check Bundle-Version of the App and ensure that the button displays "Installed" only if that particular version of the App (shown in App Store) is installed. |
Noted in https://jira.transvar.org/browse/REL-40 by [~shamika]:
See REL-40 for screen shot. "6) After releasing 3.0.0 version of this app which is compatible with IGB 10.0.0 and not with IGB 9.1.0, I could still see an option of installing the app when IGB 9.1.0 was running. After clicking on 'Install this App' the version 2.0.0 which is compatible with IGB 9.1.0 got installed. The button also changed to 'Installed' on Appstore, though a higher version of App was released on Appstore. Basically, on Appstore, it showed Installed even when the higher version was not compatible with IGB 9.1.0 and the higher version was not actually installed." Loraine comment: When App Store javascript hits the localhost IGB App Store endpoint, it should check Bundle-Version of the App and ensure that the button displays "Installed" only if that particular version of the App (shown in App Store) is installed. |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Code changes present in branch :
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2167-
Testing scenario:
Scenario 1:
1) Submit an app compatible to IGB-9.1.0.
2) Start IGB-9.1.0
Output - Install App button should be displayed
Scenario 2:
1) Submit an app compatible to IGB -10.0
2) Start IGB-9.1.0
Output - Button Get Latest IGB should be displayed
Scenario 3:
1) Submit an app compatible to IGB -10.0
2) Start IGB-10.0.0
Output - Install App button should be displayed
cc.[~aloraine]
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Please see comment on your branch. I have some concerns about how the platform_compatibility string is being used. It is editable by the submitter and should not be used to dictate button behavior and appearance. However, it is very possible I misunderstand the code!
Let's talk about it first thing tomorrow.
Yes, platform_compatibility is the string which is editable by user. But there is no other way in App Store other than platform_compatibility to identify the App compatibility with IGB.
Allowing user to edit that field can introduce error and can impact installation of the app.
We can have different solutions to prevent human errors to platform_compatibility:
1) Not allow user to change the platform_compatibility string. If user identifies any error in the string, he can email AppStore admin to change to the required platform_compatibility string. (Less efforts required for development)
2) Pre-populate the drop-down with available IGB versions and allow user to select one or many from the list (This option as discussed will need constant update to app store whenever a new igb version is added. Can be done using some REST service)
3) Add validation checks in AppStore to make sure the platform_compatibility string entered by user is correct.
cc. [~aloraine], Sameer Shanbhag
Code changes are present in branch:
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2167-#diff
cc. [~aloraine]
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Submit PR please.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Pull request submitted:
https://bitbucket.org/lorainelab/appstore/pull-requests/182/igbf-2167/diff
cc. [~aloraine]
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Deployed to https://dev-appstore-2.bioviz.org and ready for testing.
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested the ticket successfully as per the steps mentioned by Riddhi Jagdish Patil and the steps I had followed earlier. Working as expected. Moving to closed.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Riddhi Jagdish Patil - can you look at this one next? (Downloads issue is less important.)