Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Describe how code will be structured - package names, class names, location in the code base.

        Attachments

          Issue Links

            Activity

            aloraine Ann Loraine created issue -
            aloraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-2246 [ 18393 ]
            aloraine Ann Loraine made changes -
            Labels Advanced
            aloraine Ann Loraine made changes -
            Description Describe how code will be structured - package names, class names, locatoin in the code base. Describe how code will be structured - package names, class names, location in the code base.
            aloraine Ann Loraine made changes -
            Sprint Spring 3 : 3 Feb to 14 Feb [ 86 ]
            aloraine Ann Loraine made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            aloraine Ann Loraine added a comment - - edited

            Suggested structure for the project:

            Module name: File Handler Plugin - Genotyping Results
            Description: A plugin for loading and visualization results from genotyping assays, such as the 23 and Me SNP chip test results

            Code location: integrated-genome-browser/plugins/GenotypingResults

            java source code files and packages:

            • all are in package: org.lorainelab.igb.genotyping
            • GenotypeFileHandler.java - implements FileTypeHandler
            • TwentyThreeAndMeSymLoader.java - a SymLoader for reading 23 and Me results
            • TwentyThreeAndMeVariationSym.java - data structure for representing a single-base location on the genome where individuals vary (SNP) as assayed by 23 and Me genotyping chip
            • TwentyThreeAndMeVariationGlyph.java - a subclass of Glyph that draws a TwentyThreeAndMeVariationSym.java
            • GenotypingResultsFactory.java - implements factory methods for adding above Glyphs to a SeqMapView

            One doubt: The package com.affymetrix.igb.view.factories contains many classes that implement MapTierGlyphFactoryI.java. This interface seems to be the key to adding new types of data as new IGB tracks.

            One implementation class in particular seems to be doing most of the work in IGB - AnnotationGlyphFactory.java. Its first commit is 2012-09-11 by Hiral Vora and its latest commit is 2018-10-22 by Nowlan Freese. However, it is not the only such class currently in use. ProbeSetGlyphFactory.java is used to draw Affymetrix expression array probesets - see https://wiki.transvar.org/display/igbman/Visualizing+probe+sets and https://bitbucket.org/lorainelab/affyprobesetsforigb/src/master/.

            Also, all the factory classes in om.affymetrix.igb.view.factories are annotated as Components, suggesting that if we configure our project correctly, our to-be-written GenotypingResultsFactory can be selected by the framework to populate a 23 and Me track with Glyphs.

            How do we use to ensure that our new factory gets selected instead of the others? To be answered in https://jira.transvar.org/browse/IGBF-2248

            Show
            aloraine Ann Loraine added a comment - - edited Suggested structure for the project: Module name: File Handler Plugin - Genotyping Results Description: A plugin for loading and visualization results from genotyping assays, such as the 23 and Me SNP chip test results Code location: integrated-genome-browser/plugins/GenotypingResults java source code files and packages: all are in package: org.lorainelab.igb.genotyping GenotypeFileHandler.java - implements FileTypeHandler TwentyThreeAndMeSymLoader.java - a SymLoader for reading 23 and Me results TwentyThreeAndMeVariationSym.java - data structure for representing a single-base location on the genome where individuals vary (SNP) as assayed by 23 and Me genotyping chip TwentyThreeAndMeVariationGlyph.java - a subclass of Glyph that draws a TwentyThreeAndMeVariationSym.java GenotypingResultsFactory.java - implements factory methods for adding above Glyphs to a SeqMapView One doubt: The package com.affymetrix.igb.view.factories contains many classes that implement MapTierGlyphFactoryI.java. This interface seems to be the key to adding new types of data as new IGB tracks. One implementation class in particular seems to be doing most of the work in IGB - AnnotationGlyphFactory.java. Its first commit is 2012-09-11 by Hiral Vora and its latest commit is 2018-10-22 by Nowlan Freese. However, it is not the only such class currently in use. ProbeSetGlyphFactory.java is used to draw Affymetrix expression array probesets - see https://wiki.transvar.org/display/igbman/Visualizing+probe+sets and https://bitbucket.org/lorainelab/affyprobesetsforigb/src/master/ . Also, all the factory classes in om.affymetrix.igb.view.factories are annotated as Components, suggesting that if we configure our project correctly, our to-be-written GenotypingResultsFactory can be selected by the framework to populate a 23 and Me track with Glyphs. How do we use to ensure that our new factory gets selected instead of the others? To be answered in https://jira.transvar.org/browse/IGBF-2248
            aloraine Ann Loraine made changes -
            Link This issue blocks IGBF-2249 [ IGBF-2249 ]
            aloraine Ann Loraine made changes -
            Link This issue relates to IGBF-2248 [ IGBF-2248 ]
            Hide
            aloraine Ann Loraine added a comment -

            Made new issue IGBF-2251 for creating stubs for:

            • TwentyThreeAndMeVariationGlyph.java - a subclass of Glyph that draws a TwentyThreeAndMeVariationSym.java
            • GenotypingResultsFactory.java - implements factory methods for adding above Glyphs to a SeqMapView
            Show
            aloraine Ann Loraine added a comment - Made new issue IGBF-2251 for creating stubs for: TwentyThreeAndMeVariationGlyph.java - a subclass of Glyph that draws a TwentyThreeAndMeVariationSym.java GenotypingResultsFactory.java - implements factory methods for adding above Glyphs to a SeqMapView
            aloraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            aloraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Srishti Tiwari [ stiwari8 ]
            aloraine Ann Loraine made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            aloraine Ann Loraine made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            stiwari8 Srishti Tiwari (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            stiwari8 Srishti Tiwari (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            stiwari8 Srishti Tiwari (Inactive) made changes -
            Assignee Srishti Tiwari [ stiwari8 ] Ann Loraine [ aloraine ]
            Hide
            stiwari8 Srishti Tiwari (Inactive) added a comment -

            The initial code structure looks good to me.

            Show
            stiwari8 Srishti Tiwari (Inactive) added a comment - The initial code structure looks good to me.
            aloraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            aloraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            aloraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            aloraine Ann Loraine made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            aloraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

              People

              • Assignee:
                aloraine Ann Loraine
                Reporter:
                aloraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: