Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:2
-
Sprint:Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar, Spring 5 : 16 Mar to 27 Mar
Description
Situation: CyVerse allows the use of special characters, including spaces, in filenames. BioViz Connect does not handle filenames with special characters, breaking most of the right-click functionality.
Task: Handle special characters in filenames when a user clicks View in IGB and when we send requests to Terrain API.
Attachments
Issue Links
Activity
filename: stuff_!@#$%^&* space _stuff.bedGraph
Example BioViz Connect url with double encoded filename for feature_url, sym_method, and query_url and single encoded filename for sym_name:
http://127.0.0.1:7085/IGBControl?
version=?&
loadresidues=false&
cyverse_data=true&
feature_url_0=https://data.cyverse.org/dav-anon/iplant/home/nowlanf/SmokeTesting/H_sapiens_Dec_2013/stuff_!%2540%2523%2524%2525%255E%2526*%2520space%2520_stuff.bedGraph&
sym_method_0=https://data.cyverse.org/dav-anon/iplant/home/nowlanf/SmokeTesting/H_sapiens_Dec_2013/stuff_!%2540%2523%2524%2525%255E%2526*%2520space%2520_stuff.bedGraph&
sym_col_0=0x0F0F0F&
sym_bg_0=0x0FFFF0&
sym_name_0=stuff_!%40%23%24%25%5E%26*%20space%20_stuff.bedGraph&
query_url=https://data.cyverse.org/dav-anon/iplant/home/nowlanf/SmokeTesting/H_sapiens_Dec_2013/stuff_!%2540%2523%2524%2525%255E%2526*%2520space%2520_stuff.bedGraph&
server_url=cyverse
Pull Request Link: https://bitbucket.org/nfreese/django-cyversedev/pull-requests/135/igbf-2275/diff
As per previous comment, The parameter 'Filepath' has been encoded twice before sending it as URL query parameter to avoid failure.
Code changes have also been done to change the way we are sending the FilePath as a query parameter in many scenarios such as Manage Link. Instead changes are made to send the FilePath as Json Body to avoid failure parsing any filename with special characters.
Moving to Needs Testing. Nowlan Freese can you please test this ticket and move it done if everything works fine.
I think there might be an issue with the sym_name not being encoded. The sym_name parameter is not showing correctly in the debugger for stuff_!@#$%^&* space _stuff.bedGraph when clicking View in IGB in BioViz Connect.
Terrain functionality appears to be working correctly, the three right-panels are loading correctly.
Encoding the sym_name worked, file is loading in IGB, name is showing correctly.
Closing issue.
It looks like for BioViz Connect to work, need to double encode the filename for feature_url, sym_method, and query_url and single encode the filename for sym_name.