Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2273

Revert changes to URL encoding in bookmarks

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar

      Description

      Situation: Need to revert changes to how the bookmark url encoding works in order to get bookmarks to work with special characters.

      Task: Revert changes to bookmark url encoding.

        Attachments

          Issue Links

            Activity

            Hide
            nfreese Nowlan Freese added a comment - - edited

            Changes made in IGBF-32 were interfering with bookmarks created from files with spaces being loaded correctly. As the associated changes in the Galaxy codebase associated with IGBF-32 were not pushed, I reverted the changes in the directlyLoadFile and loadUnknownData methods. The loadUnknownData method was also modified to match the loadCyVerseDataMethod (now removed) from IGBF-1632. The loadUnknownData method now does not load a custom genome if a user is already in a genome when opening data that is not associated with a genome.

            To test:
            To test IGB bookmarks, load the attached files into IGB and create a bookmark. Remove the files from IGB and then double-click on the bookmark to see if it loads correctly.

            My IGB branch with changes: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-2273-SpaceInName

            Show
            nfreese Nowlan Freese added a comment - - edited Changes made in IGBF-32 were interfering with bookmarks created from files with spaces being loaded correctly. As the associated changes in the Galaxy codebase associated with IGBF-32 were not pushed, I reverted the changes in the directlyLoadFile and loadUnknownData methods. The loadUnknownData method was also modified to match the loadCyVerseDataMethod (now removed) from IGBF-1632 . The loadUnknownData method now does not load a custom genome if a user is already in a genome when opening data that is not associated with a genome. To test: To test IGB bookmarks, load the attached files into IGB and create a bookmark. Remove the files from IGB and then double-click on the bookmark to see if it loads correctly. My IGB branch with changes: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-2273-SpaceInName
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            I have tested the issue using the instructions mentioned above.
            1) Downloaded the files and the branch installer.
            2) Opened those files and created a bookmark.
            3) Removed those files and selected a different genome.
            4) Double clicked bookmark to check if the custom genome is not being loaded if a user is already in a genome when opening data that is not associated with a genome.
            Everything is working fine. Nowlan Freese, please go ahead and submit a PR for the same.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - I have tested the issue using the instructions mentioned above. 1) Downloaded the files and the branch installer. 2) Opened those files and created a bookmark. 3) Removed those files and selected a different genome. 4) Double clicked bookmark to check if the custom genome is not being loaded if a user is already in a genome when opening data that is not associated with a genome. Everything is working fine. Nowlan Freese , please go ahead and submit a PR for the same.
            Show
            nfreese Nowlan Freese added a comment - Pull Request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/775/fix-bookmark-issue-when-filename-has/diff
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            Nowlan Freese - Bookmarks are getting loaded but once I close IGB and try to reload, null pointer exception is thrown.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Nowlan Freese - Bookmarks are getting loaded but once I close IGB and try to reload, null pointer exception is thrown.
            Hide
            nfreese Nowlan Freese added a comment -

            The issue Noor found is an existing issue with how bookmarks works with custom genomes. What is happening is that when a user loads data without selecting a genome, IGB creates a custom genome. The data is then loaded within this custom genome. When the user creates a bookmark, the version is set as custom genome. When the user closes IGB the custom genome is removed. When the user reopens IGB and tries to load the bookmark, IGB cannot find a genome version of custom genome, and thus generates a null pointer. This behavior has been around for a while. CyVerse and Galaxy use a separate bookmark logic to load custom genomes to avoid this problem. This seems like an edge case as I'm not sure how often users would be creating bookmarks in custom genomes.

            Since the other functionality appears to be working, I'm closing this issue.

            Show
            nfreese Nowlan Freese added a comment - The issue Noor found is an existing issue with how bookmarks works with custom genomes. What is happening is that when a user loads data without selecting a genome, IGB creates a custom genome. The data is then loaded within this custom genome. When the user creates a bookmark, the version is set as custom genome. When the user closes IGB the custom genome is removed. When the user reopens IGB and tries to load the bookmark, IGB cannot find a genome version of custom genome, and thus generates a null pointer. This behavior has been around for a while. CyVerse and Galaxy use a separate bookmark logic to load custom genomes to avoid this problem. This seems like an edge case as I'm not sure how often users would be creating bookmarks in custom genomes. Since the other functionality appears to be working, I'm closing this issue.

              People

              • Assignee:
                nfreese Nowlan Freese
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: