Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2356

Fix distorted images in genome dashboard

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Many of the images in the new genome dashboard application look distorted.

          For example, the image for the cow genome looks great when viewed on its own, but in the Dashboard App it looks compressed in the horizontal dimenion.

          Compare:

          to

          The problem is that the images need to be perfectly square to look nice in the Dashboard.

          For this task, examine each image and crop it as needed to make it look nice.

          Before starting work on this, consult with Sameer Shanbhag (app developer) for advice or tips he may have.

          Also, please note that all pull requests should go to master branch on his repository.

          Use this repository for branching and submitting PRs: https://bitbucket.org/lorainelab/genome-dashboard

          (Once Sameer is back we'll submit PRs to his upstream repo.)

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-2399 Avoid colliding image names for species

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                This was in the "In Progress" column and assigned to myself.
                I'm pretty sure you were working on it, so I'm re-assigning to yourself. Can you let me know if that is the right thing?

                Show
                ann.loraine Ann Loraine added a comment - - edited This was in the "In Progress" column and assigned to myself. I'm pretty sure you were working on it, so I'm re-assigning to yourself. Can you let me know if that is the right thing?
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Update:

                Sameer Shanbhag looked into this and ruled out the possibility of doing this remotely. Therefore we need somebody to look carefully at all the images and crop them as needed to make them perfectly square.

                Show
                ann.loraine Ann Loraine added a comment - Update: Sameer Shanbhag looked into this and ruled out the possibility of doing this remotely. Therefore we need somebody to look carefully at all the images and crop them as needed to make them perfectly square.
                Hide
                Permalink
                stiwari8 Srishti Tiwari (Inactive) added a comment -

                Please review:

                https://bitbucket.org/srishtitiwari/genome-dashboard/branch/IGBF-2356#diff

                Show
                stiwari8 Srishti Tiwari (Inactive) added a comment - Please review: https://bitbucket.org/srishtitiwari/genome-dashboard/branch/IGBF-2356#diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Could you check B_taurus image?
                Looks like the new image is 3377 × 2847 pixels instead of square.

                Show
                ann.loraine Ann Loraine added a comment - Could you check B_taurus image? Looks like the new image is 3377 × 2847 pixels instead of square.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Also, I noticed that the image for C_sativa is a photo of Cannabis sativa. It should actually be a photo of Camelina sativa. We have a name collision

                This is Camelina sativa (false flax): https://en.wikipedia.org/wiki/Camelina_sativa

                Show
                ann.loraine Ann Loraine added a comment - Also, I noticed that the image for C_sativa is a photo of Cannabis sativa. It should actually be a photo of Camelina sativa. We have a name collision This is Camelina sativa (false flax): https://en.wikipedia.org/wiki/Camelina_sativa
                Hide
                Permalink
                stiwari8 Srishti Tiwari (Inactive) added a comment -

                Hi Dr. Loraine, I added the changes. Please have a look:
                https://bitbucket.org/srishtitiwari/genome-dashboard/branch/IGBF-2356#commits

                Show
                stiwari8 Srishti Tiwari (Inactive) added a comment - Hi Dr. Loraine, I added the changes. Please have a look: https://bitbucket.org/srishtitiwari/genome-dashboard/branch/IGBF-2356#commits
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Thanks!

                Please submit PR to master branch on lorainelab repository.

                Show
                ann.loraine Ann Loraine added a comment - Thanks! Please submit PR to master branch on lorainelab repository.
                Hide
                Permalink
                stiwari8 Srishti Tiwari (Inactive) added a comment -

                PR Submitted:

                https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/2/igbf-2356/diff

                Show
                stiwari8 Srishti Tiwari (Inactive) added a comment - PR Submitted: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/2/igbf-2356/diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged. Will deploy shortly to test.bioviz.org.

                Show
                ann.loraine Ann Loraine added a comment - Merged. Will deploy shortly to test.bioviz.org.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Changes deployed. Everybody's looking good!

                cc: Srishti Tiwari and Sameer Shanbhag

                Show
                ann.loraine Ann Loraine added a comment - Changes deployed. Everybody's looking good! cc: Srishti Tiwari and Sameer Shanbhag

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: