Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      0.5
    • Sprint:
      Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun

      Description

      The new genome dashboard application (https://www.bioviz.org/genome-dashboard) shows images representing different species for which genome sequence data are avaiable.

      When users click an image, the latest genome version for the featured species is supposed to load into IGB.

      However, this only works if IGB is currently running.

      So the Genome Dashboard App has some code that checks to see if IGB is running.

      If IGB is not running, then it shows a popup to let them know to start IGB.

      The wording of the popup is currently a little confusing for users because it uses programming-focused terminology. See attached for the current designed.

      For this task, modify the popup so that it uses language that is more understandable.

      In addition, modify the "Download" button on the popup as follows:

        Attachments

          Issue Links

            Activity

            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - - edited

            Please review code changes: https://bitbucket.org/pnikhare/genome-dashboard/branch/IGBF-2386#diff

            • Changed "IGB Service unavailable" to "IGB Application is not Running"
            • Changed css for the Download button.
            • Modification to open https://www.bioviz.org/download.html in a new tab on click of "Download now" button.
              Prof [~aloraine] , Please let me know if any words to be changed.
            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - - edited Please review code changes: https://bitbucket.org/pnikhare/genome-dashboard/branch/IGBF-2386#diff Changed "IGB Service unavailable" to "IGB Application is not Running" Changed css for the Download button. Modification to open https://www.bioviz.org/download.html in a new tab on click of "Download now" button. Prof [~aloraine] , Please let me know if any words to be changed.
            Hide
            ann.loraine Ann Loraine added a comment -

            Ready for pull request - please proceed.

            cc: Pooja Nikhare

            Show
            ann.loraine Ann Loraine added a comment - Ready for pull request - please proceed. cc: Pooja Nikhare
            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - Submitted PR : https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/4/igbf-2386-modify-igb-is-not-running-popup/commits
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged.

            Show
            ann.loraine Ann Loraine added a comment - Merged.
            Hide
            ann.loraine Ann Loraine added a comment -

            Latest code visible on test.bioviz.org/genome-dashboard

            Show
            ann.loraine Ann Loraine added a comment - Latest code visible on test.bioviz.org/genome-dashboard
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            Tested this ticket. The latest code changes are visible on https://test.bioviz.org/genome-dashboard which reflect the message change in Popup window. It now says "IGB Application is not Running". The Download button resembles the one on https://www.bioviz.org/download.html and it redirects to https://www.bioviz.org/download.html by opening a new tab.
            Moving to closed.
            cc: Prof. [~aloraine]
            Thank you for merging it and letting me know.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - Tested this ticket. The latest code changes are visible on https://test.bioviz.org/genome-dashboard which reflect the message change in Popup window. It now says "IGB Application is not Running". The Download button resembles the one on https://www.bioviz.org/download.html and it redirects to https://www.bioviz.org/download.html by opening a new tab. Moving to closed. cc: Prof. [~aloraine] Thank you for merging it and letting me know.
            Hide
            ann.loraine Ann Loraine added a comment -

            Change request:

            • Can this be modified so that a new window and just a new tab opens?

            cc: Pooja Nikhare

            Show
            ann.loraine Ann Loraine added a comment - Change request: Can this be modified so that a new window and just a new tab opens? cc: Pooja Nikhare
            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - - edited

            Similar to onclick of Integrated Genome Browser on title "Start Integrated Genome Browser. Then click a species open its genome" ?

            This can be done.

            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - - edited Similar to onclick of Integrated Genome Browser on title "Start Integrated Genome Browser. Then click a species open its genome" ? This can be done.
            Hide
            ann.loraine Ann Loraine added a comment -

            Actually, not exactly.

            What I am hoping for is a new browser window to be opened – with URL entry bar and everything. That is, the same thing that would appear in a new tab, but in a separate window.

            Show
            ann.loraine Ann Loraine added a comment - Actually, not exactly. What I am hoping for is a new browser window to be opened – with URL entry bar and everything. That is, the same thing that would appear in a new tab, but in a separate window.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Maybe it is not possible – it depends on the browser:

            https://www.thesitewizard.com/html-tutorial/open-links-in-new-window-or-tab.shtml

            Also, Sameer had looked into it as well:

            https://jira.transvar.org/browse/IGBF-2368

            Show
            ann.loraine Ann Loraine added a comment - - edited Maybe it is not possible – it depends on the browser: https://www.thesitewizard.com/html-tutorial/open-links-in-new-window-or-tab.shtml Also, Sameer had looked into it as well: https://jira.transvar.org/browse/IGBF-2368
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Since it is not possible to open a functionally complete browser window, use the solution that Sameer has implemented for the link labeled "Integrated Genome Browser" shown in the Genome Dashboard page's sub-title heading.

            To complete this task:

            • Examine the code Sameer has used - see link in sub-title
            • Re-use it for the link shown in the "IGB is not running" popup.

            Also, change the popup wording a bit:

            • Change "IGB Application is Not Running" to "To view a genome, start IGB"

            Then change the body of the popup to read:

            Don't have IGB? No problem!

            then display the current "Download Now" button.

            Show
            ann.loraine Ann Loraine added a comment - - edited Since it is not possible to open a functionally complete browser window, use the solution that Sameer has implemented for the link labeled "Integrated Genome Browser" shown in the Genome Dashboard page's sub-title heading. To complete this task: Examine the code Sameer has used - see link in sub-title Re-use it for the link shown in the "IGB is not running" popup. Also, change the popup wording a bit: Change "IGB Application is Not Running" to "To view a genome, start IGB" Then change the body of the popup to read: Don't have IGB? No problem! then display the current "Download Now" button.
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged.

            Show
            ann.loraine Ann Loraine added a comment - Merged.
            Hide
            ann.loraine Ann Loraine added a comment -

            Deployed to https://test.bioviz.org/genome-dashboard.

            Latest deployed commit:

            • daabc8e IGBF-2386: Modify IGB-is-not-running popup
            Show
            ann.loraine Ann Loraine added a comment - Deployed to https://test.bioviz.org/genome-dashboard . Latest deployed commit: daabc8e IGBF-2386 : Modify IGB-is-not-running popup
            Hide
            ann.loraine Ann Loraine added a comment -

            To complete the ticket, make the changes described above. (See comment added 21/May/20 above)

            Show
            ann.loraine Ann Loraine added a comment - To complete the ticket, make the changes described above. (See comment added 21/May/20 above)
            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - Please see my changes here: https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/commits/79227ba1f8f20982196ca7faa2a5b37e8dde14b0
            Hide
            ann.loraine Ann Loraine added a comment -

            Deployed to https://test.bioviz.org/genome-dashboard and ready for testing.

            Show
            ann.loraine Ann Loraine added a comment - Deployed to https://test.bioviz.org/genome-dashboard and ready for testing.
            Hide
            nfreese Nowlan Freese added a comment -

            Tested https://test.bioviz.org/genome-dashboard on mac.

            Popup occurs when IGB is not running with requested text:

            To view a genome, start IGB
            Don't have IGB? No problem!

            Download Now Close

            Closing issue.

            Show
            nfreese Nowlan Freese added a comment - Tested https://test.bioviz.org/genome-dashboard on mac. Popup occurs when IGB is not running with requested text: To view a genome, start IGB Don't have IGB? No problem! Download Now Close Closing issue.

              People

              • Assignee:
                pbadzuh Philip Badzuh (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: