Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun
Description
Situation: On https://test.bioviz.org/genome-dashboard, if I load the dashboard page when IGB is not running, then start IGB, then click on a genome in the dashboard, I get the popup informing me to start IGB.
If I have IGB running when I load the dashboard page, then close IGB, then click on a genome in the dashboard, I receive a notification that "This site can’t be reached".
Task: Change when the genome dashboard checks if IGB is running to each time a genome is clicked.
Attachments
Issue Links
Activity
Code looks good.
For functional testing, have deployed https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2407 to https://test.bioviz.org/genome-dashboard.
Tested on https://test.bioviz.org/genome-dashboard
Page is getting IGB status each time genome clicked on. Working correctly.
Ready for pull request.
Tested https://www.bioviz.org/genome-dashboard on Mac (10.14.6) with Chrome, Firefox, and Safari.
Chrome and Firefox are working correctly.
Philip Badzuh Safari (13.1.1) is behaving oddly. It doesn't seem like it is able to communicate with IGB, and the Install IGB button is a gray color.
Edit: From console when trying to load data:
[blocked] The page at https://www.bioviz.org/genome-dashboard was not allowed to display insecure content from http://127.0.0.1:7085/igbStatusCheck.
Please see my branch for the latest commit, which fixes safari not rendering button color correctly.
https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2407#diff
I did not experience any content blocking issue you mentioned in safari on my machine, and from a quick google search, it seems that it may be an issue with user security preferences. See post here
My user account is fairly new, and I didn't change the setting mentioned in the post above, so I assume this shouldn't be an issue by default.
Looks fine to me. Please submit PR.
Post merge testing:
1. Genome Dashboard loads the genome on IGB as expected if IGB is launched after the loading of the Genome Dashboard.
2. If IGB was already launched at the time of loading the Genome Dashboard, but closed before opening a genome on the dashboard, no errors would be sent to the user and the dashboard asks the user to launch IGB as intended.
- The problems mentioned in this ticket are all resolved.
Steps I took to check the problem of Dashboard not detecting that IGB is running (If IGB is launched after the loading of the Genome Dashboard):
1. Loaded https://www.bioviz.org/genome-dashboard
2. Launched IGB
3. Chose a genome to open in IGB on the dashboard
Results: Genome Dashboard successfully knew that IGB was running and did not ask me to launch it. IGB Loaded the genome chosen successfully
Steps I took to check the problem of the Genome Dashboard not detecting that IGB was closed and throwing an error message:
1. Launched IGB
2. Loaded https://www.bioviz.org/genome-dashboard
3. Closed IGB
4. Chose a genome to open in IGB on the dashboard
Results: No error messages was thrown, and the Genome Dashboard successfully detected that IGB was closed at the time of me clicking "View in IGB" button on Dashboard.
Dashboard asks the user to launch IGB, as expected.
Moving this ticket to done and re-assigning this ticket to Philip Badzuh
Please review my branch here:
https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2407#diff