Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Blocker
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.25
-
Epic Link:
-
Sprint:Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 Jul, Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul
Description
Situation: In BioViz Connect users can click on the button "View in IGB" to view a file in IGB (IGB must be running). In the Chrome browser, this works correctly without any kinds of issues or warnings. However, when testing Safari (13.1.1) on Mac (10.14.6) when I (Nowlan) click on View in IGB I receive the following error in the browser console:
The page at https://connect.bioviz.org/base/#/iplant/home/nowlanf/SmokeTesting/H_sapiens_Dec_2013 was not allowed to display insecure content from http://127.0.0.1:7085/igbStatusCheck.
It appears that Safari views this as a security issue and is blocking the browser from talking with IGB.
To replicate:
Open IGB
Open Safari
In Safari, go to bioviz.org/connect.html
Login using the nowlanf credentials (ask Nowlan for password).
Once logged in, navigate to https://connect.bioviz.org/base/#/iplant/home/nowlanf/SmokeTesting/H_sapiens_Dec_2013
Click on View in IGB for any file.
Make note if the file is opened in IGB, or if an error occurs in the Safari console.
Task: Attempt to replicate the issue on a Mac in Safari.
If the issue cannot be replicated then make a note of it in the Comments section of this issue and include the Mac and Safari versions.
If the issue can be replicated, include any console errors, Mac version, and Safari version in the Comments section of this issue.
Attachments
Issue Links
- relates to
-
IGBF-2987 Fix Galaxy IGB CORS issue
-
- Closed
-
-
-
- Closed
-
-
IGBF-2674 Handle Safari error in App Store
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
Activity
Next steps:
- Investigate Microsoft Edge. Does it have the same problem?
- Review Web logs to determine browsers used by people
Tested on Mac 10.14.6 with Microsoft Edge 4.0.522.44
Tested BioViz Connect and IGB App Store. Both worked correctly, did not see the issue occurring on Safari.
In working with the genome dashboard code, I noticed that requests made to the https IGB API endpoints do not fail when done so by changing the browser's window location using javascript. This makes sense, since the Mixed Content errors that occur in safari and potentially other browsers result because unsecured requests are being made from within a secured connection, however, to my understanding, changing the window location initializes a new connection.
An example of a successful request
window.location = 'http://localhost:7085/bringIGBToFront';
Good news! Maybe we can try it with App Store or bar.js next?
attn: Nowlan Freese and Philip Badzuh
Sure, that sounds good. I'll make a new ticket to see if this can be implemented in the app store.
I was able to replicate the issue described by Nowlan Freese, both in bioviz connect and genome dashboard when testing on the live sites. When running locally genome dashboard locally, however, I had no errors. After doing some research, this appears to be a CORS issue - safari is complaining that IGB doesn't explicitly allow cross origin requests. To solve this, I have modified the IGB API endpoint, 'http://127.0.0.1:7085/igbStatusCheck', to respond with an additional header that should prevent this error.
Please see the change at my branch below:
https://bitbucket.org/pbadzuh/igb_pbdev/branch/IGBF-2420#diff