Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23, Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11
Description
Situation: Changes were made to IGB to allow for the View in IGB button to work correctly from BioViz Connect. Versions earlier than 9.1.4 of IGB may not function correctly.
Task: Using the endpoint identified in IGBF-2504 add additional logic to check the IGB version when a user clicks View in IGB. This logic would be after the current logic to check that IGB is running. If IGB is running and the version in less than IGB 9.1.4, notify the user that they need to update their version of IGB.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-2376 [ 18533 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Sprint | Fall 1: 14 Sep - 25 Sep [ 103 ] | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct [ 103, 104 ] |
| Rank | Ranked higher |
| Comment |
[ During the meeting I thought I heard this was ready for review? If yes, do please move ahead on the board. If you need feedback before that, let me know.
attn: [~chaitanya] ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Assignee | Chaitanya Kintali [ chaitanya ] | Nowlan Freese [ nfreese ] |
Dr. Loraine has agreed to do a patch release to 9.1.5 that will include the changes to the IGB endpoint that will return the version number.
Chaitanya Kintali please make two code changes:
1) Update the version number to check for IGB 9.1.5 as that will be the first version of IGB to return the version number.
2) Warn the user that their version of IGB is less than version 9.1.5 and may not work correctly with BioViz Connect, then attempt to load the data in IGB. IGB version 9.1.2 and 9.1.4 should work correctly with BioViz Connect, but we have no way of telling if that is the version that the user has if they are using a version less than 9.1.5.
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Assignee | Nowlan Freese [ nfreese ] | Chaitanya Kintali [ chaitanya ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Updated Pull Request:
https://bitbucket.org/nfreese/django-cyversedev/pull-requests/196/igbf-2532/diff
Moving to Pull Request Submitted.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Chaitanya Kintali [ chaitanya ] | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Link | This issue is blocked by IGBF-2554 [ IGBF-2554 ] |
I will merge the pull request once IGB 9.1.5 has been released (IGBF-2554).
| Sprint | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct [ 103, 104 ] | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23 [ 103, 104, 106 ] |
| Rank | Ranked higher |
| Sprint | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23 [ 103, 104, 106 ] | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23, Fall 4 Oct 26 - Nov 6 [ 103, 104, 106, 107 ] |
| Rank | Ranked higher |
| Sprint | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23, Fall 4 Oct 26 - Nov 6 [ 103, 104, 106, 107 ] | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23, Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20 [ 103, 104, 106, 107, 108 ] |
| Rank | Ranked higher |
| Sprint | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23, Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20 [ 103, 104, 106, 107, 108 ] | Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23, Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20, Fall 6 Nov 23 - Dec 4 [ 103, 104, 106, 107, 108, 109 ] |
| Rank | Ranked higher |
Karthik Raveendran - Can you create a new branch for 2532, copy over Chaitanya's code and merge it in? The old pull requests now have merge conflicts in cyverse.js. We also need to update the minimum igb version to 9.1.6
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Nowlan Freese [ nfreese ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Working well, I have text change requests.
Put a line break between the two sentences.
Change text to:
Older versions of IGB may not work correctly with BioViz Connect.
Please update to the newest version of IGB.
| Assignee | Nowlan Freese [ nfreese ] | Karthik Raveendran [ karthik ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Closing issue.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Karthik Raveendran [ karthik ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Pull Request Link:
https://bitbucket.org/nfreese/django-cyversedev/pull-requests/194
Moving to Needs Testing.