Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2532

Check IGB version when user clicks View in IGB

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          2
        • Epic Link:
        • Sprint:
          Fall 1: 14 Sep - 25 Sep, Fall 2: 28 Sep - 9 Oct, Fall 3: Oct 12 - Oct 23, Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11

          Description

          Situation: Changes were made to IGB to allow for the View in IGB button to work correctly from BioViz Connect. Versions earlier than 9.1.4 of IGB may not function correctly.

          Task: Using the endpoint identified in IGBF-2504 add additional logic to check the IGB version when a user clicks View in IGB. This logic would be after the current logic to check that IGB is running. If IGB is running and the version in less than IGB 9.1.4, notify the user that they need to update their version of IGB.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-2504 Investigate Check for IGB version

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-2546 Modify IGB status check endpoint to return the IGB version

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                chaitanya Chaitanya Kintali (Inactive) added a comment -

                Pull Request Link:
                https://bitbucket.org/nfreese/django-cyversedev/pull-requests/194

                Moving to Needs Testing.

                Show
                chaitanya Chaitanya Kintali (Inactive) added a comment - Pull Request Link: https://bitbucket.org/nfreese/django-cyversedev/pull-requests/194 Moving to Needs Testing.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Dr. Loraine has agreed to do a patch release to 9.1.5 that will include the changes to the IGB endpoint that will return the version number.

                Chaitanya Kintali please make two code changes:
                1) Update the version number to check for IGB 9.1.5 as that will be the first version of IGB to return the version number.
                2) Warn the user that their version of IGB is less than version 9.1.5 and may not work correctly with BioViz Connect, then attempt to load the data in IGB. IGB version 9.1.2 and 9.1.4 should work correctly with BioViz Connect, but we have no way of telling if that is the version that the user has if they are using a version less than 9.1.5.

                Show
                nfreese Nowlan Freese added a comment - Dr. Loraine has agreed to do a patch release to 9.1.5 that will include the changes to the IGB endpoint that will return the version number. Chaitanya Kintali please make two code changes: 1) Update the version number to check for IGB 9.1.5 as that will be the first version of IGB to return the version number. 2) Warn the user that their version of IGB is less than version 9.1.5 and may not work correctly with BioViz Connect, then attempt to load the data in IGB. IGB version 9.1.2 and 9.1.4 should work correctly with BioViz Connect, but we have no way of telling if that is the version that the user has if they are using a version less than 9.1.5.
                Hide
                Permalink
                chaitanya Chaitanya Kintali (Inactive) added a comment - - edited

                Updated Pull Request:
                https://bitbucket.org/nfreese/django-cyversedev/pull-requests/196/igbf-2532/diff

                Moving to Pull Request Submitted.

                Show
                chaitanya Chaitanya Kintali (Inactive) added a comment - - edited Updated Pull Request: https://bitbucket.org/nfreese/django-cyversedev/pull-requests/196/igbf-2532/diff Moving to Pull Request Submitted.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                I will merge the pull request once IGB 9.1.5 has been released (IGBF-2554).

                Show
                nfreese Nowlan Freese added a comment - I will merge the pull request once IGB 9.1.5 has been released (IGBF-2554).
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Karthik Raveendran - Can you create a new branch for 2532, copy over Chaitanya's code and merge it in? The old pull requests now have merge conflicts in cyverse.js. We also need to update the minimum igb version to 9.1.6

                Show
                nfreese Nowlan Freese added a comment - Karthik Raveendran - Can you create a new branch for 2532, copy over Chaitanya's code and merge it in? The old pull requests now have merge conflicts in cyverse.js. We also need to update the minimum igb version to 9.1.6
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/218/igbf-2532-check-igb-version-when-user

                Show
                nfreese Nowlan Freese added a comment - Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/218/igbf-2532-check-igb-version-when-user
                Hide
                Permalink
                nfreese Nowlan Freese added a comment - - edited

                Working well, I have text change requests.

                Put a line break between the two sentences.
                Change text to:
                Older versions of IGB may not work correctly with BioViz Connect.
                Please update to the newest version of IGB.

                Show
                nfreese Nowlan Freese added a comment - - edited Working well, I have text change requests. Put a line break between the two sentences. Change text to: Older versions of IGB may not work correctly with BioViz Connect. Please update to the newest version of IGB.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment - - edited

                Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/221/igbf-2532-remove-mention-of-915-in-the

                Show
                nfreese Nowlan Freese added a comment - - edited Merged https://bitbucket.org/nfreese/django-cyversedev/pull-requests/221/igbf-2532-remove-mention-of-915-in-the
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Closing issue.

                Show
                nfreese Nowlan Freese added a comment - Closing issue.

                  People

                  • Assignee:
                    karthik Karthik Raveendran
                    Reporter:
                    nfreese Nowlan Freese
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: