Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2546

Modify IGB status check endpoint to return the IGB version

    Details

      Description

        Attachments

          Issue Links

            Activity

            Hide
            noor91zahara Noor Zahara added a comment - - edited

            I see an extra import that is not necessary - import static com.affymetrix.common.CommonUtils.IGB_NAME;
            We can remove this!
            Ann Loraine -What do you suggest?

            Otherwise the code looks good and works fine.

            Show
            noor91zahara Noor Zahara added a comment - - edited I see an extra import that is not necessary - import static com.affymetrix.common.CommonUtils.IGB_NAME; We can remove this! Ann Loraine -What do you suggest? Otherwise the code looks good and works fine.
            Hide
            aloraine Ann Loraine added a comment -

            Yes, I agree. Thank you for catching this!
            I have already merged it, though.
            Noor Zahara - Would you add a new commit that deletes the unneeded import? What do you think?

            Show
            aloraine Ann Loraine added a comment - Yes, I agree. Thank you for catching this! I have already merged it, though. Noor Zahara - Would you add a new commit that deletes the unneeded import? What do you think?
            Hide
            noor91zahara Noor Zahara added a comment - - edited

            I can do that as a part of another ticket.

            Closing the ticket.

            Show
            noor91zahara Noor Zahara added a comment - - edited I can do that as a part of another ticket. Closing the ticket.
            Hide
            aloraine Ann Loraine added a comment -

            Sure - that sounds great. Please make the ticket and proceed at your convenience.

            Show
            aloraine Ann Loraine added a comment - Sure - that sounds great. Please make the ticket and proceed at your convenience.
            Hide
            aloraine Ann Loraine added a comment - - edited

            To-do:

            • Please confirm that the un-needed import has been removed. If not, remove it and/or confirm that the import is required.
            • Please use Postman or other REST API tool to confirm that IGB statusCheck returns the version

            Note: We have already confirmed that other applications that use this pre-existing endpoint are OK with the change. Note that the change is that the 'var' previously was "True" and did not indicate the version.

            Show
            aloraine Ann Loraine added a comment - - edited To-do: Please confirm that the un-needed import has been removed. If not, remove it and/or confirm that the import is required. Please use Postman or other REST API tool to confirm that IGB statusCheck returns the version Note: We have already confirmed that other applications that use this pre-existing endpoint are OK with the change. Note that the change is that the 'var' previously was "True" and did not indicate the version.

              People

              • Assignee:
                noor91zahara Noor Zahara
                Reporter:
                aloraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: