Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2546

Modify IGB status check endpoint to return the IGB version

    Details

      Description

        Attachments

          Issue Links

            Activity

            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment -

            Modified http://127.0.0.1:7085/igbStatusCheck to return
            "var igbVersion = 9.1.6"
            instead of
            "var isIgbRunning=True"

            [~aloraine] Please check the postman api response to check the sample response and let me know if it is fine.

            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - Modified http://127.0.0.1:7085/igbStatusCheck to return "var igbVersion = 9.1.6" instead of "var isIgbRunning=True" [~aloraine] Please check the postman api response to check the sample response and let me know if it is fine.
            Hide
            nfreese Nowlan Freese added a comment - - edited

            May need to double-check anything that hits this endpoint (bar/galaxy) to see if they are looking for a 200 response code or if they are actually validating the response (var isIgbRunning=True).

            Show
            nfreese Nowlan Freese added a comment - - edited May need to double-check anything that hits this endpoint (bar/galaxy) to see if they are looking for a 200 response code or if they are actually validating the response (var isIgbRunning=True).
            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment -

            Nowlan Freese
            I have double-checked both AppStore and galaxy, bioviz to check if they are validating whether IGB is running based upon the response. It seems they are just checking the status 200 to detect wether igb is running or not. I have tested that on my local machine by browsing both appstore and galaxy to open files using the IGB version which does not return isIGBRunning and tested, it seems to be working fine.

            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - Nowlan Freese I have double-checked both AppStore and galaxy, bioviz to check if they are validating whether IGB is running based upon the response. It seems they are just checking the status 200 to detect wether igb is running or not. I have tested that on my local machine by browsing both appstore and galaxy to open files using the IGB version which does not return isIGBRunning and tested, it seems to be working fine.
            Hide
            ann.loraine Ann Loraine added a comment -

            Request for Chaitanya Kintali:

            • Could you remove the spaces flanking the = (equals) character?
            • Please provide a link to your branch for code review.
            Show
            ann.loraine Ann Loraine added a comment - Request for Chaitanya Kintali : Could you remove the spaces flanking the = (equals) character? Please provide a link to your branch for code review.
            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment -
            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - Code Branch with spaces removed: https://bitbucket.org/ckintali/igb-ckintalifork/branch/IGBF-2546
            Hide
            ann.loraine Ann Loraine added a comment -

            Please submit PR when ready.

            attn: Chaitanya Kintali

            Show
            ann.loraine Ann Loraine added a comment - Please submit PR when ready. attn: Chaitanya Kintali
            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment - - edited

            Pull Request Link:
            https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/830/igbf-2546/diff

            Since, Pull Request is merged, Moving to Needs Testing.

            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - - edited Pull Request Link: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/830/igbf-2546/diff Since, Pull Request is merged, Moving to Needs Testing.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment - - edited

            I see an extra import that is not necessary - import static com.affymetrix.common.CommonUtils.IGB_NAME;
            We can remove this!
            [~aloraine] -What do you suggest?

            Otherwise the code looks good and works fine.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - - edited I see an extra import that is not necessary - import static com.affymetrix.common.CommonUtils.IGB_NAME; We can remove this! [~aloraine] -What do you suggest? Otherwise the code looks good and works fine.
            Hide
            ann.loraine Ann Loraine added a comment -

            Yes, I agree. Thank you for catching this!
            I have already merged it, though.
            Noor Zahara - Would you add a new commit that deletes the unneeded import? What do you think?

            Show
            ann.loraine Ann Loraine added a comment - Yes, I agree. Thank you for catching this! I have already merged it, though. Noor Zahara - Would you add a new commit that deletes the unneeded import? What do you think?
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment - - edited

            I can do that as a part of another ticket.

            Closing the ticket.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - - edited I can do that as a part of another ticket. Closing the ticket.
            Hide
            ann.loraine Ann Loraine added a comment -

            Sure - that sounds great. Please make the ticket and proceed at your convenience.

            Show
            ann.loraine Ann Loraine added a comment - Sure - that sounds great. Please make the ticket and proceed at your convenience.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            To-do:

            • Please confirm that the un-needed import has been removed. If not, remove it and/or confirm that the import is required.
            • Please use Postman or other REST API tool to confirm that IGB statusCheck returns the version

            Note: We have already confirmed that other applications that use this pre-existing endpoint are OK with the change. Note that the change is that the 'var' previously was "True" and did not indicate the version.

            Show
            ann.loraine Ann Loraine added a comment - - edited To-do: Please confirm that the un-needed import has been removed. If not, remove it and/or confirm that the import is required. Please use Postman or other REST API tool to confirm that IGB statusCheck returns the version Note: We have already confirmed that other applications that use this pre-existing endpoint are OK with the change. Note that the change is that the 'var' previously was "True" and did not indicate the version.

              People

              • Assignee:
                noor91zahara Noor Zahara (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: