Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      There is something a bit wonky with the the app store tiles. Sometimes the categories are shown on the tiles themselves, sometimes not.

      To repeat, do the following steps (using Chrome or other browser in incognito window to ensure you are using the latest css, or clear cache first):

      • Go to https://devappstore5.bioviz.org (latest master branch code)
      • Click "Plugin" (under App type)
      • Observe that "Plugin" appears on some but not all the tiles (see 1.png)
      • Now click "Any" (under App type)
      • Observe that now suddenly all the tiles are showing their associated categories (2.png)

        Attachments

        1. 1.png
          1.png
          237 kB
        2. 2.png
          2.png
          284 kB
        3. nav_panel.js.jpg
          nav_panel.js.jpg
          17 kB

          Activity

          Show
          chirag24 Chirag Chandrahas Shetty added a comment - Submitted PR. Link: https://bitbucket.org/lorainelab/appstore/pull-requests/249
          Hide
          aloraine Ann Loraine added a comment - - edited

          Merged and deployed to https://devappstore5.bioviz.org. Ready for testing.

          Show
          aloraine Ann Loraine added a comment - - edited Merged and deployed to https://devappstore5.bioviz.org . Ready for testing.
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment - - edited

          I have a Question regarding the changes done in this commit:

          • Triggering the event for radio buttons in unnecessary:
            -
            $(function() { $("input[type=radio]").trigger('change'); }

            );

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - - edited I have a Question regarding the changes done in this commit: https://bitbucket.org/lorainelab/appstore/commits/cf06c5afabfe377757799a06535f5fc1a5db0fa0 Triggering the event for radio buttons in unnecessary: - $(function() { $("input[type=radio]").trigger('change'); } );
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment - - edited

          Recommendation:

          • Make a function which would segregate all the things inside the current checked event
          • call that function when the js loads
          • we can use that function when the checked event is invoked as well as in any other event / refresh

          Three Reasons to do it this way:

          • As we are segregating things in to a function, function name makes it easy for the developer to understand what's going on inside that function
          • Can be called from any other place without code repetition
          • Adding comment above the function is also a good idea to make it extremely clear on what exactly is happening

          P.S. Please refer to the Screenshot of the code attached that does the things I explained.

          Attn: Chirag Chandrahas Shetty Ann Loraine

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - - edited Recommendation: Make a function which would segregate all the things inside the current checked event call that function when the js loads we can use that function when the checked event is invoked as well as in any other event / refresh Three Reasons to do it this way: As we are segregating things in to a function, function name makes it easy for the developer to understand what's going on inside that function Can be called from any other place without code repetition Adding comment above the function is also a good idea to make it extremely clear on what exactly is happening P.S. Please refer to the Screenshot of the code attached that does the things I explained. Attn: Chirag Chandrahas Shetty Ann Loraine
          Hide
          aloraine Ann Loraine added a comment -

          I am not sure I understand the proposed change, but it sounds like it will make the code easier to understand and maintain. Please make the change as you see fit.

          attn: Sameer Shanbhag

          Show
          aloraine Ann Loraine added a comment - I am not sure I understand the proposed change, but it sounds like it will make the code easier to understand and maintain. Please make the change as you see fit. attn: Sameer Shanbhag
          Show
          sameer Sameer Shanbhag (Inactive) added a comment - - edited Pull Request Submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/256/igbf-2709-improve-code-readability-and C.C. Ann Loraine
          Hide
          aloraine Ann Loraine added a comment -

          Merged and deployed to https://devappstore3.bioviz.org

          Show
          aloraine Ann Loraine added a comment - Merged and deployed to https://devappstore3.bioviz.org
          Hide
          chirag24 Chirag Chandrahas Shetty added a comment -

          Looks Good. Closing the ticket.

          Show
          chirag24 Chirag Chandrahas Shetty added a comment - Looks Good. Closing the ticket.

            People

            • Assignee:
              chirag24 Chirag Chandrahas Shetty
              Reporter:
              aloraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: