Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3001

Handle data sources with improper SSL certificates

    Details

    • Story Points:
      1
    • Sprint:
      Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 24, Fall 8 2021 Nov 29 - Dec 10, Fall 9 2021 Dec 13 - Dec 24

      Description

      See the discussion here for details on the problem and a potential solution.

        Attachments

        1. Data.png
          Data.png
          133 kB
        2. datasource.png
          datasource.png
          70 kB
        3. error - secies.png
          error - secies.png
          571 kB
        4. error - URL.png
          error - URL.png
          697 kB

          Issue Links

            Activity

            pbadzuh Philip Badzuh (Inactive) created issue -
            pbadzuh Philip Badzuh (Inactive) made changes -
            Field Original Value New Value
            Epic Link IGBF-1765 [ 17855 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Link This issue relates to IGBF-2964 [ IGBF-2964 ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            Please see my changes here.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - Please see my changes here .
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            I have a question about this:

                                    if ((urlDomainComponents[urlDomainComponents.length - 1] + urlDomainComponents[urlDomainComponents.length - 2])
            +                                .equals(certDomainComponents[certDomainComponents.length - 1] + certDomainComponents[certDomainComponents.length - 2])) {
            +                            return true;
            +                        }
            

            Wouldn't it be better to first use built-in, default checking provided by the base classes, and then, only if that fails, apply this additional logic to catch situations where a subdomain (e.g., "foo" in foo.example.com) fails to match the common name?

            Show
            ann.loraine Ann Loraine added a comment - - edited I have a question about this: if ((urlDomainComponents[urlDomainComponents.length - 1] + urlDomainComponents[urlDomainComponents.length - 2]) + .equals(certDomainComponents[certDomainComponents.length - 1] + certDomainComponents[certDomainComponents.length - 2])) { + return true ; + } Wouldn't it be better to first use built-in, default checking provided by the base classes, and then, only if that fails, apply this additional logic to catch situations where a subdomain (e.g., "foo" in foo.example.com) fails to match the common name?
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Philip Badzuh [ pbadzuh ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 6 2021 Oct 25 - Nov 5 [ 132 ] Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 19 [ 132, 133 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Rank Ranked lower
            ann.loraine Ann Loraine made changes -
            Sprint Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 24 [ 132, 133 ] Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 24, Fall 8 2021 Nov 29 - Dec 10 [ 132, 133, 134 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 24, Fall 8 2021 Nov 29 - Dec 10 [ 132, 133, 134 ] Fall 6 2021 Oct 25 - Nov 5, Fall 7 2021 Nov 8 - Nov 24, Fall 8 2021 Nov 29 - Dec 10, Fall 9 2021 Dec 13 - Dec 24 [ 132, 133, 134, 135 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            Unfortunately, after trying to find a built-in method for parsing the domain and top level domain of a hostname, I was not able to identify any. The URL class can only provide parsing capabilities to the entire hostname level i.e. including any subdomains via the getAuthority() method documented here.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - Unfortunately, after trying to find a built-in method for parsing the domain and top level domain of a hostname, I was not able to identify any. The URL class can only provide parsing capabilities to the entire hostname level i.e. including any subdomains via the getAuthority() method documented here .
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Philip Badzuh - thank you for looking into it again. Please submit PR.

            Show
            ann.loraine Ann Loraine added a comment - Philip Badzuh - thank you for looking into it again. Please submit PR.
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            No problem. Please see PR here.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - No problem. Please see PR here .
            pbadzuh Philip Badzuh (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged to master branch. Running master branch pipeline on bitbucket to build windows, mac, linux installers.

            Show
            ann.loraine Ann Loraine added a comment - Merged to master branch. Running master branch pipeline on bitbucket to build windows, mac, linux installers.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Installers built and available from main repository downloads section.
            Also, deployed new master branch to bioviz main's "early access igb" page.
            Ready for testing, but some instructions are needed on how to test as it's a bit challenging to figure it out from this ticket and its linked ticket(s).
            Philip Badzuh: Please provide new instructions on how to test the changes, including:

            • description of the bug from the users' perspective
            • how to check that the bug is fixed
            Show
            ann.loraine Ann Loraine added a comment - - edited Installers built and available from main repository downloads section . Also, deployed new master branch to bioviz main's "early access igb" page. Ready for testing, but some instructions are needed on how to test as it's a bit challenging to figure it out from this ticket and its linked ticket(s). Philip Badzuh : Please provide new instructions on how to test the changes, including: description of the bug from the users' perspective how to check that the bug is fixed
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Assignee Philip Badzuh [ pbadzuh ]
            Hide
            ann.loraine Ann Loraine added a comment -

            To test, add the following URL to IGB as a new IGB Quickload data source, using a localhost-deployed trackhub facade site.

            http://localhost:8000/api/?hubUrl=https://dashr2.lisanwanglab.org/tracks/DASHR2_hub.txt&filePath=/
            

            Next, attempt to load some of the data files from the Quickload source.

            If the bug is still in effect, you will observe IGB reporting "feature is not reachable" style of error as mentioned in the title of IGBF-2964: "Investigate: “This feature is not reachable” error"

            Show
            ann.loraine Ann Loraine added a comment - To test, add the following URL to IGB as a new IGB Quickload data source, using a localhost-deployed trackhub facade site. http: //localhost:8000/api/?hubUrl=https://dashr2.lisanwanglab.org/tracks/DASHR2_hub.txt&filePath=/ Next, attempt to load some of the data files from the Quickload source. If the bug is still in effect, you will observe IGB reporting "feature is not reachable" style of error as mentioned in the title of IGBF-2964 : "Investigate: “This feature is not reachable” error"
            omarne Omkar Marne (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ] Omkar Marne [ omarne ]
            ann.loraine Ann Loraine made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment Error.png [ 17024 ]
            Hide
            omarne Omkar Marne (Inactive) added a comment - - edited

            I ran trackhub-facade site locally. After trying above URL I got an error. Please see attached screenshot. My guess is URL is incorrect.

            Dr [~aloraine] Please provide the correct the URL if its incorrect.

            Show
            omarne Omkar Marne (Inactive) added a comment - - edited I ran trackhub-facade site locally. After trying above URL I got an error. Please see attached screenshot. My guess is URL is incorrect. Dr [~aloraine] Please provide the correct the URL if its incorrect.
            omarne Omkar Marne (Inactive) made changes -
            Attachment Error.png [ 17024 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment Error.png [ 17025 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            You need to get the URL from Philip Badzuh. (The above URL is from Philip during scrum)

            Show
            ann.loraine Ann Loraine added a comment - You need to get the URL from Philip Badzuh . (The above URL is from Philip during scrum)
            omarne Omkar Marne (Inactive) made changes -
            Assignee Omkar Marne [ omarne ] Philip Badzuh [ pbadzuh ]
            omarne Omkar Marne (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Post-merge Testing In Progress [ 10003 ] To-Do [ 10305 ]
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment -

            The error that relates to this ticket is specific to the IGB application, so you should:

            • Make sure you can add the provided URL as a data source in IGB
            • Open a an organism/genome combination supported by the trackhub that defines the URL. In this case, you can try homo sapiens, genome hg38 (the first genome in the IGB dropdown)
            • Select and load a file in the available data panel folder associated with the URL.
            • Observe that no error popup is shown in IGB.

            The warning you observed in your browser results from an issue with the content-type in the response of the endpoint not matching the actual content, but the data is still transmitted - you can use developer tools to confirm or try the same request using postman. This should be fixed in a new ticket as it's misleading, however, it shouldn't block you from testing this ticket.

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - The error that relates to this ticket is specific to the IGB application, so you should: Make sure you can add the provided URL as a data source in IGB Open a an organism/genome combination supported by the trackhub that defines the URL. In this case, you can try homo sapiens, genome hg38 (the first genome in the IGB dropdown) Select and load a file in the available data panel folder associated with the URL. Observe that no error popup is shown in IGB. The warning you observed in your browser results from an issue with the content-type in the response of the endpoint not matching the actual content, but the data is still transmitted - you can use developer tools to confirm or try the same request using postman. This should be fixed in a new ticket as it's misleading, however, it shouldn't block you from testing this ticket.
            pbadzuh Philip Badzuh (Inactive) made changes -
            Assignee Philip Badzuh [ pbadzuh ] Omkar Marne [ omarne ]
            omarne Omkar Marne (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            omarne Omkar Marne (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            omarne Omkar Marne (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Needs 1st Level Review [ 10005 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            omarne Omkar Marne (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            omarne Omkar Marne (Inactive) made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment error - URL.png [ 17035 ]
            Hide
            omarne Omkar Marne (Inactive) added a comment - - edited

            When I added the above URL as a data source in IGB, I got an error saying 'Following servers are not responding - Trackhub' ( Name of the data source). I was not able to select the species and genome version.

            Please check the attached snapshots.

            Dr. [~aloraine] Philip Badzuh Please check.

            Show
            omarne Omkar Marne (Inactive) added a comment - - edited When I added the above URL as a data source in IGB, I got an error saying 'Following servers are not responding - Trackhub' ( Name of the data source). I was not able to select the species and genome version. Please check the attached snapshots. Dr. [~aloraine] Philip Badzuh Please check.
            omarne Omkar Marne (Inactive) made changes -
            Attachment error - secies.png [ 17036 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment Error.png [ 17025 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment Data.png [ 17039 ]
            omarne Omkar Marne (Inactive) made changes -
            Attachment datasource.png [ 17040 ]
            Hide
            omarne Omkar Marne (Inactive) added a comment - - edited

            After installing the latest IGB release and enabling the IGB quick load data source, the data from the localhost data source is visible. Please see attached snapshots.

            Closing the ticket.

            Show
            omarne Omkar Marne (Inactive) added a comment - - edited After installing the latest IGB release and enabling the IGB quick load data source, the data from the localhost data source is visible. Please see attached snapshots. Closing the ticket.
            omarne Omkar Marne (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            omarne Omkar Marne (Inactive) made changes -
            Assignee Omkar Marne [ omarne ] Philip Badzuh [ pbadzuh ]
            pbadzuh Philip Badzuh (Inactive) made changes -
            Link This issue relates to IGBF-3087 [ IGBF-3087 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-3130 [ IGBF-3130 ]
            nfreese Nowlan Freese made changes -
            Fix Version/s 9.1.10 Major Release [ 10700 ]
            nfreese Nowlan Freese made changes -
            Issue Type Task [ 3 ] Improvement [ 4 ]

              People

              • Assignee:
                pbadzuh Philip Badzuh (Inactive)
                Reporter:
                pbadzuh Philip Badzuh (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: