Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-3202

ProtAnnot: Update link to third party webpage

    Details

      Description

      In the ProtAnnot app, a link connecting to an InterPro web page takes the user to a '404 page not found' page which will redirect to the correct page. Replace the existing link with the working link: http://www.ebi.ac.uk/interpro/about/interpro/

      To find the dead link in ProtAnnot:
      1. Open IGB.
      2. Plug-ins > Launch App Manager
      3. Install ProtAnnot
      4. Open a genome
      5. Click and drag to select some data to compare
      6. In upper left, Tools > Start ProtAnnot
      7. In ProtAnnot, click Run InterProScan...
      8. In the new Job Configuration window, in bottom left notice the link "visit the Interpro Web page at EBI."
      9. Clicking this link takes the user to "http://www.ebi.ac.uk/interpro/about.html/". Which is not valid, but redirects to the site's current About page.

      Change the link so it takes the user directly to the InterPro About page: "http://www.ebi.ac.uk/interpro/about/interpro/"

        Attachments

          Issue Links

            Activity

            Hide
            kgopu Kaushik Gopu added a comment - - edited

            Link has been updated and tested in local.
            Link to branch IGBF-3202

            Show
            kgopu Kaushik Gopu added a comment - - edited Link has been updated and tested in local. Link to branch IGBF-3202
            Hide
            ann.loraine Ann Loraine added a comment -

            During scrum discussed how to transform Downloads directory to an app repository for testers' convenience. Kaushik Gopu to proceed with doing this extra step prior to review.

            Show
            ann.loraine Ann Loraine added a comment - During scrum discussed how to transform Downloads directory to an app repository for testers' convenience. Kaushik Gopu to proceed with doing this extra step prior to review.
            Hide
            kgopu Kaushik Gopu added a comment -

            I ran the pipeline and it was successful. jar files are downloaded to the download folder of the bitbucket. moving to first level review.
            https://bitbucket.org/kaushik-gopu/kgopu_proant/downloads/

            Show
            kgopu Kaushik Gopu added a comment - I ran the pipeline and it was successful. jar files are downloaded to the download folder of the bitbucket. moving to first level review. https://bitbucket.org/kaushik-gopu/kgopu_proant/downloads/
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on Mac on IGB 9.1.10.

            The link now goes to the correct InterPro page. However, I would like to make one additional request. Please go to the https link instead of http (https://www.ebi.ac.uk/interpro/about/interpro/).

            Show
            nfreese Nowlan Freese added a comment - Tested on Mac on IGB 9.1.10. The link now goes to the correct InterPro page. However, I would like to make one additional request. Please go to the https link instead of http ( https://www.ebi.ac.uk/interpro/about/interpro/ ).
            Hide
            kgopu Kaushik Gopu added a comment -

            I have updated the protocol and now it is using https. please test it again. I am attaching link of the new jar below.
            https://bitbucket.org/kaushik-gopu/kgopu_proant/downloads/

            Show
            kgopu Kaushik Gopu added a comment - I have updated the protocol and now it is using https. please test it again. I am attaching link of the new jar below. https://bitbucket.org/kaushik-gopu/kgopu_proant/downloads/
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on Mac on IGB 9.1.10.

            The link to Interpro (https://www.ebi.ac.uk/interpro/about/interpro/) is working correctly and using https.

            Ready for pull request.

            Show
            nfreese Nowlan Freese added a comment - Tested on Mac on IGB 9.1.10. The link to Interpro ( https://www.ebi.ac.uk/interpro/about/interpro/ ) is working correctly and using https. Ready for pull request.
            Hide
            kgopu Kaushik Gopu added a comment - - edited

            pull request has been submitted and it ready for review.
            https://bitbucket.org/kaushik-gopu/kgopu_proant/pull-requests/2/IGBF-3202

            Show
            kgopu Kaushik Gopu added a comment - - edited pull request has been submitted and it ready for review. https://bitbucket.org/kaushik-gopu/kgopu_proant/pull-requests/2/IGBF-3202
            Hide
            ann.loraine Ann Loraine added a comment -

            A question came up about the choice of URL in the change. Why not use https://www.ebi.ac.uk/interpro/? I feel like keeping the URL simple in this way will make it more likely to endure.

            Comments welcome!

            Show
            ann.loraine Ann Loraine added a comment - A question came up about the choice of URL in the change. Why not use https://www.ebi.ac.uk/interpro/? I feel like keeping the URL simple in this way will make it more likely to endure. Comments welcome!
            Hide
            nfreese Nowlan Freese added a comment -

            I have no preference regarding which interpro page the link goes to. The original link went to interpro/about.html so that is why the updated link went to the /interpro/about/interpro/ page.

            Kaushik Gopu - For the pull request, please squash commits instead of reverting. This is a good blog on squashing: https://www.internalpointers.com/post/squash-commits-into-one-git

            Show
            nfreese Nowlan Freese added a comment - I have no preference regarding which interpro page the link goes to. The original link went to interpro/about.html so that is why the updated link went to the /interpro/about/interpro/ page. Kaushik Gopu - For the pull request, please squash commits instead of reverting. This is a good blog on squashing: https://www.internalpointers.com/post/squash-commits-into-one-git
            Hide
            kgopu Kaushik Gopu added a comment -

            Dr freese, I have opted out for git reset instead of squashing due to merge conflicts. The reason was all changes were made in single file and this is causing conflict issues. However, the tree looks clean now after reset.
            Incase if you want to test it again:
            https://bitbucket.org/kaushik-gopu/kgopu_proant/downloads/
            Here is the link for new pull request:
            https://bitbucket.org/kaushik-gopu/kgopu_proant/pull-requests/3

            Show
            kgopu Kaushik Gopu added a comment - Dr freese, I have opted out for git reset instead of squashing due to merge conflicts. The reason was all changes were made in single file and this is causing conflict issues. However, the tree looks clean now after reset. Incase if you want to test it again: https://bitbucket.org/kaushik-gopu/kgopu_proant/downloads/ Here is the link for new pull request: https://bitbucket.org/kaushik-gopu/kgopu_proant/pull-requests/3
            Hide
            ann.loraine Ann Loraine added a comment -

            Sorry, one more issue;

            The target for the PR is your own repository. You should select the upstream (team) repository for the PR target.

            Show
            ann.loraine Ann Loraine added a comment - Sorry, one more issue; The target for the PR is your own repository. You should select the upstream (team) repository for the PR target.
            Hide
            kgopu Kaushik Gopu added a comment -

            apologize for the mistake. I did not noticed while submitting.
            I tried to edit the old request but for some reason it is not showing team repo in dropdown. however, I have created a new one. here is the link
            https://bitbucket.org/lorainelab/protannot/pull-requests/14

            Show
            kgopu Kaushik Gopu added a comment - apologize for the mistake. I did not noticed while submitting. I tried to edit the old request but for some reason it is not showing team repo in dropdown. however, I have created a new one. here is the link https://bitbucket.org/lorainelab/protannot/pull-requests/14
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            My apologies. I should have noticed this before.
            Since the code for the has changed, we need to increment the version.

            Review concept of "semantic versioning" with major, minor, and micro versioning conventions.
            See: https://semver.org/

            Show
            ann.loraine Ann Loraine added a comment - - edited My apologies. I should have noticed this before. Since the code for the has changed, we need to increment the version. Review concept of "semantic versioning" with major, minor, and micro versioning conventions. See: https://semver.org/
            Hide
            kgopu Kaushik Gopu added a comment - - edited

            I have updated the patch(micro) version (since it is a bug fix) in pom.xml file and now jar file is pointing to 9.1.4. I think that's the only change required for version change.

            Show
            kgopu Kaushik Gopu added a comment - - edited I have updated the patch(micro) version (since it is a bug fix) in pom.xml file and now jar file is pointing to 9.1.4. I think that's the only change required for version change.
            Hide
            kgopu Kaushik Gopu added a comment -

            I have updated the version of the project. https://bitbucket.org/kaushik-gopu/kgopu_proant/downloads/
            The new version of the jar has been build in the downloads folder of the repo.

            Show
            kgopu Kaushik Gopu added a comment - I have updated the version of the project. https://bitbucket.org/kaushik-gopu/kgopu_proant/downloads/ The new version of the jar has been build in the downloads folder of the repo.
            Hide
            nfreese Nowlan Freese added a comment -

            Tested ProtAnnot version from Kaushik's downloads folder. When installed on IGB release 9.1.10 version shows as 9.1.4.

            Ready for pull request.

            Show
            nfreese Nowlan Freese added a comment - Tested ProtAnnot version from Kaushik's downloads folder. When installed on IGB release 9.1.10 version shows as 9.1.4. Ready for pull request.
            Hide
            kgopu Kaushik Gopu added a comment -

            Squashed the commits to keep repository history readable and understandable.
            Ready for pull request: https://bitbucket.org/kaushik-gopu/kgopu_proant/pull-requests/4

            Show
            kgopu Kaushik Gopu added a comment - Squashed the commits to keep repository history readable and understandable. Ready for pull request: https://bitbucket.org/kaushik-gopu/kgopu_proant/pull-requests/4
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            PR is now merged. Ready for testing.

            To test, add this location as a new bundle repository (app store):

            Test this using IGB version 9.1.10 or lower. Version higher than 9.1.10 will not work because it will use/have a different google guava library version than what is being used by the App.

            Show
            ann.loraine Ann Loraine added a comment - - edited PR is now merged. Ready for testing. To test, add this location as a new bundle repository (app store): https://bitbucket.org/lorainelab/protannot/downloads/ Test this using IGB version 9.1.10 or lower. Version higher than 9.1.10 will not work because it will use/have a different google guava library version than what is being used by the App.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            I installed ProtAnnot using the "downloads" folder as the bundle repository and confirmed that the link now works.
            However, I discovered what appears to be a new problem.
            When I attempted to run an InterPro Search, the search failed with the following error. Lines lines preceding the error are included for context.

            01:20:10.863 INFO com.affymetrix.igb.IGB - Completed loading sequence for Chr1 : 7,284,963 - 7,290,069 from IGB Quickload http://lorainelab-quickload.scidas.org/quickload/
            01:21:04.688 INFO o.l.i.p.i.InterProscanServiceRest - iprscan5-R20230710-072102-0693-74435734-p1m
            01:21:05.129 ERROR o.l.i.p.i.InterProscanServiceRest - No enum constant org.lorainelab.igb.protannot.interproscan.api.InterProscanService.Status.QUEUED
            java.lang.IllegalArgumentException: No enum constant org.lorainelab.igb.protannot.interproscan.api.InterProscanService.Status.QUEUED
            at java.lang.Enum.valueOf(Enum.java:238) ~[na:1.8.0_332]
            at org.lorainelab.igb.protannot.interproscan.api.InterProscanService$Status.valueOf(InterProscanService.java:29) ~[-1688969961404:na]
            at org.lorainelab.igb.protannot.interproscan.InterProscanServiceRest.status(InterProscanServiceRest.java:106) ~[-1688969961404:na]
            at org.lorainelab.igb.protannot.ProtAnnotService$5.run(ProtAnnotService.java:692) [-1688969961404:na]
            at java.util.TimerThread.mainLoop(Timer.java:555) [na:1.8.0_332]
            at java.util.TimerThread.run(Timer.java:505) [na:1.8.0_332]
            01:21:05.130 INFO o.l.igb.protannot.ProtAnnotService - iprscan5-R20230710-072102-0693-74435734-p1m Error

            Opening a new ticket (IGBF-3381) to investigate / reproduce the error, and then fix the error.

            Show
            ann.loraine Ann Loraine added a comment - - edited I installed ProtAnnot using the "downloads" folder as the bundle repository and confirmed that the link now works. However, I discovered what appears to be a new problem. When I attempted to run an InterPro Search, the search failed with the following error. Lines lines preceding the error are included for context. 01:20:10.863 INFO com.affymetrix.igb.IGB - Completed loading sequence for Chr1 : 7,284,963 - 7,290,069 from IGB Quickload http://lorainelab-quickload.scidas.org/quickload/ 01:21:04.688 INFO o.l.i.p.i.InterProscanServiceRest - iprscan5-R20230710-072102-0693-74435734-p1m 01:21:05.129 ERROR o.l.i.p.i.InterProscanServiceRest - No enum constant org.lorainelab.igb.protannot.interproscan.api.InterProscanService.Status.QUEUED java.lang.IllegalArgumentException: No enum constant org.lorainelab.igb.protannot.interproscan.api.InterProscanService.Status.QUEUED at java.lang.Enum.valueOf(Enum.java:238) ~ [na:1.8.0_332] at org.lorainelab.igb.protannot.interproscan.api.InterProscanService$Status.valueOf(InterProscanService.java:29) ~ [-1688969961404:na] at org.lorainelab.igb.protannot.interproscan.InterProscanServiceRest.status(InterProscanServiceRest.java:106) ~ [-1688969961404:na] at org.lorainelab.igb.protannot.ProtAnnotService$5.run(ProtAnnotService.java:692) [-1688969961404:na] at java.util.TimerThread.mainLoop(Timer.java:555) [na:1.8.0_332] at java.util.TimerThread.run(Timer.java:505) [na:1.8.0_332] 01:21:05.130 INFO o.l.igb.protannot.ProtAnnotService - iprscan5-R20230710-072102-0693-74435734-p1m Error Opening a new ticket ( IGBF-3381 ) to investigate / reproduce the error, and then fix the error.

              People

              • Assignee:
                kgopu Kaushik Gopu
                Reporter:
                rweidenh Logan Weidenhammer (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: