Details

    • Type: Improvement
    • Status: First Level Review in Progress (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Task: Update the HTSJDK to the most recent version (see https://github.com/samtools/htsjdk/releases). Currently the Loraine Lab has its own version of the HTSJDK. As part of this ticket, investigate whether we can switch to using the official HTSJDK.

      Note that HTSJDK versions greater than 4 are officially compatible with JDK 17. IGB uses JDK 21 so we may encounter some issues upgrading.

        Attachments

          Issue Links

            Activity

            Hide
            kgopu Kaushik Gopu added a comment - - edited
            • BIGWIG: Upgraded many things, such as HTSHDK, Java, Gradle, and other dependencies in the BigWig Project. Gradle upgrade led to changing some of the APIs in the build.gradle file. BigWid build was successful.
            • IGB: the build was successful after upgrading the HTSJDK and BigWig ( which uses HTSJDK and Java 21) versions. However, IGB is throwing bundle exceptions while running the project.
            • Will continue to work on resolving issues that occurred after the upgrade.
            Show
            kgopu Kaushik Gopu added a comment - - edited BIGWIG : Upgraded many things, such as HTSHDK, Java, Gradle, and other dependencies in the BigWig Project. Gradle upgrade led to changing some of the APIs in the build.gradle file. BigWid build was successful. IGB : the build was successful after upgrading the HTSJDK and BigWig ( which uses HTSJDK and Java 21) versions. However, IGB is throwing bundle exceptions while running the project. Will continue to work on resolving issues that occurred after the upgrade.
            Hide
            kgopu Kaushik Gopu added a comment - - edited

            Instructions for testing:

            • fetch this bigwig branch into your local.
            • clean the.m2, local maven repository, before you execute the following commands:
              Build and install artifact to local
              ./gradlew clean build
              
              ./gradlew publishToMavenLocal
              

              Note: For Windows, use gradle.bat file instead of gradlew.

            • fetch this IGB branch into your local. This branch uses Samtools htsjdk 4.1.0 and bigwig 3.0.0 (uses htsjdk 4.1.0 and jdk 21) dependencies.
            • Maven commands
              mvn clean build
              
            • run the IGB, and while testing, monitor the logs. Test bam, sam, cram, bigbedhandler, and bigwighandler features, as these plugins use htsjdk and bigwig dependencies.

            Question for Nowlan Freese

            • With this upgrade, IGB no longer supports the BAI feature. How would you like to proceed with the BAI plugin further? Do you want to delete (or) disable it? Let me know your thoughts.
            Show
            kgopu Kaushik Gopu added a comment - - edited Instructions for testing: fetch this bigwig branch into your local. clean the.m2, local maven repository, before you execute the following commands: Build and install artifact to local ./gradlew clean build ./gradlew publishToMavenLocal Note: For Windows, use gradle.bat file instead of gradlew. fetch this IGB branch into your local. This branch uses Samtools htsjdk 4.1.0 and bigwig 3.0.0 (uses htsjdk 4.1.0 and jdk 21) dependencies. Maven commands mvn clean build run the IGB, and while testing, monitor the logs. Test bam, sam, cram, bigbedhandler, and bigwighandler features, as these plugins use htsjdk and bigwig dependencies. Question for Nowlan Freese With this upgrade, IGB no longer supports the BAI feature. How would you like to proceed with the BAI plugin further? Do you want to delete (or) disable it? Let me know your thoughts.
            Hide
            nfreese Nowlan Freese added a comment -

            My steps for testing:

            For BigWig: I fetched Kaushik's bigwig branch. I needed to upgrade my gradle in order to build (now at 8.7).

            brew upgrade gradle
            gradle clean build
            gradle publishToMavenLocal
            

            I then fetched Kaushik's IGB 3671 branch.
            I tested all of the files in the smoke testing quickload, including bigwig, bigbed, bam, sam, cram, and vcf. All files loaded as expected, no errors in the logs.

            Next step: I want to double check with Kaushik that we have the versioning of the bigwig artifact correct before deploying. Otherwise everything appears to be working.

            Show
            nfreese Nowlan Freese added a comment - My steps for testing: For BigWig: I fetched Kaushik's bigwig branch. I needed to upgrade my gradle in order to build (now at 8.7). brew upgrade gradle gradle clean build gradle publishToMavenLocal I then fetched Kaushik's IGB 3671 branch. I tested all of the files in the smoke testing quickload, including bigwig, bigbed, bam, sam, cram, and vcf. All files loaded as expected, no errors in the logs. Next step: I want to double check with Kaushik that we have the versioning of the bigwig artifact correct before deploying. Otherwise everything appears to be working.

              People

              • Assignee:
                nfreese Nowlan Freese
                Reporter:
                nfreese Nowlan Freese
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: