Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 10.2.0
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Spring 3, Spring 4
Description
Remove the implemented Ensembl code for REST API integration. After the discussion, as the REST API is gonna be deprecated in a few years, we decided not to integrate Ensembl via REST API, instead we plan to use their new GraphQL interface to query and integrate it in the future.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-3555 [ 22774 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Tested Sravani's branch on Mac.
- IGB builds and runs without errors.
- Recently added species appear correctly in the Species dropdown.
- Code changes look good.
Ready for pull request.
| Assignee | Nowlan Freese [ nfreese ] | Jaya Sravani Sirigineedi [ jsirigin ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Sprint | Spring 3 [ 212 ] | Spring 3, Spring 4 [ 212, 213 ] |
| Rank | Ranked higher |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Assignee | Ann Loraine [ aloraine ] |
PR merged, installers built and deployed to early access on bioviz.org.
Ready for final testing.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested main branch installer on Mac.
Everything working as expected, no errors in log, no Ensembl data provider.
Closing ticket.
| Assignee | Jaya Sravani Sirigineedi [ jsirigin ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Fix Version/s | 10.2.0 [ 11100 ] |
Reverted the commits, removed the ensembl code and resolved the conflicts as well, here is the branch: https://bitbucket.org/jaya-sravani/integrated-genome-browser/branch/IGBF-4138. Code changes look good to me and tested the app as well, IGB is started and genomes are loading, everything seems to work as expected.
Note when testing: Check whether the new genomes that are added recently are still present as there were some conflicts that I resolved in the species.txt. There shouldn't be any issue.