Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1344

graph operations don't handle inverse 0 well

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      0.25
    • Sprint:
      Fall 4 Oct 26 - Nov 6, Fall 5 Nov 9 - Nov 20, Fall 6 Nov 30 - Dec 11, Fall 7 Dec 14 - Dec 23, Winter 1 Dec 28 - Jan 8, Winter 2 Jan 11 - Jan 22, Winter 3 Jan 25 - Feb 5

      Description

      Graph tracks can have regions with value=0.
      One of the graph track operations is the inverse function, and several other functions include an inverse.
      But the inverse of 0 is infinity.
      IGB needs to handle this.

      Currently, if you take the inverse of a graph track where the value is 0, the y-max for the resulting track is set to 340282346638528860000000000000000000000, and the values on the Y-axis end in "Y", and all the values that have legit values are squished down to be invisible, so the entire track appears blank.

      The inverse function just needs to have a catch to handle this. If input is 0, output is NA.

        Attachments

          Issue Links

            Activity

            Hide
            nfreese Nowlan Freese added a comment -

            Tested on mac using 1344 dmg installer from Supreeth's branch.

            Tested using attached test files. Working correctly.

            Sai Supreeth Segu ready for pull request.

            Show
            nfreese Nowlan Freese added a comment - Tested on mac using 1344 dmg installer from Supreeth's branch. Tested using attached test files. Working correctly. Sai Supreeth Segu ready for pull request.
            Hide
            ssegu Sai Supreeth Segu added a comment - - edited
            Show
            ssegu Sai Supreeth Segu added a comment - - edited Ann Loraine - Please review my pull request Link for pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/849/igbf-1344-fixing-inverse-0-value
            Hide
            ssegu Sai Supreeth Segu added a comment -

            Dr. Ann Loraine and Dr. Nowlan Freese, I have updated the pull request with a commit. Please review the pull request.
            Link for pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/849/igbf-1344-fixing-inverse-0-value

            Show
            ssegu Sai Supreeth Segu added a comment - Dr. Ann Loraine and Dr. Nowlan Freese , I have updated the pull request with a commit. Please review the pull request. Link for pull request: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/849/igbf-1344-fixing-inverse-0-value
            Hide
            aloraine Ann Loraine added a comment -

            Nowlan Freese - please confirm that the requested functionality is implemented in released IGB version 9.1.6.

            Show
            aloraine Ann Loraine added a comment - Nowlan Freese - please confirm that the requested functionality is implemented in released IGB version 9.1.6.
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on release 9.1.6 on Mac using the attached bedgraph files.

            Applying inverse to a value of 0 in the graph operations now results in a value of infinity.

            Closing issue.

            Show
            nfreese Nowlan Freese added a comment - Tested on release 9.1.6 on Mac using the attached bedgraph files. Applying inverse to a value of 0 in the graph operations now results in a value of infinity. Closing issue.

              People

              • Assignee:
                ssegu Sai Supreeth Segu
                Reporter:
                ieclabau Ivory Blakley
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: