Details

    • Type: New Feature
    • Status: To-Do (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      3
    • Sprint:
      Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1

      Description

      A research at University of Freiburg in Germany has requested better support for setting color schemes for data loaded from GFF files.

      Please see linked issue HELP-321 for details.

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-1765 [ 17855 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to HELP-321 [ HELP-321 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Description A user at University of Freiburg in Germany has requested better support for setting color schemes for data loaded from GFF files.

            He writes:

            gelhausr@informatik.uni-freiburg.de
            A research at University of Freiburg in Germany has requested better support for setting color schemes for data loaded from GFF files.

            He writes:

            ann.loraine Ann Loraine made changes -
            Description A research at University of Freiburg in Germany has requested better support for setting color schemes for data loaded from GFF files.

            He writes:

            A research at University of Freiburg in Germany has requested better support for setting color schemes for data loaded from GFF files.

            Please see linked issue HELP-321 for details.

            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Un-assigning to give another devloper a chance to pick this up since NZ & ST discovered a good fix for IGBF-1552 & NZ will be working on that next.

            Show
            ann.loraine Ann Loraine added a comment - Un-assigning to give another devloper a chance to pick this up since NZ & ST discovered a good fix for IGBF-1552 & NZ will be working on that next.
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ]
            prutha Prutha Kulkarni (Inactive) made changes -
            Assignee Prutha Kulkarni [ prutha ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Prutha Kulkarni [ prutha ] Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Some useful links regarding the issue shared by Dr.Freese http://igbquickload.org/smokeTestingQuickload/H_sapiens_Dec_2013/GFF3/ https://genome.ucsc.edu/FAQ/FAQformat.html#format3 https://wiki.transvar.org/display/igbman/Track+lines+for+configuring+track+appearance
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9 [ 68 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10 [ 68, 69 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment - - edited
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - - edited Code changes : https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1835#diff [~aloraine] Kindly help review the code.
            noor91zahara Noor Zahara (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Just a few change requests:

            • Please do not add core/igb/src/main/resources/git.properties.
            • Can you please squash all the changes into a single commit?
            Show
            ann.loraine Ann Loraine added a comment - Just a few change requests: Please do not add core/igb/src/main/resources/git.properties. Can you please squash all the changes into a single commit?
            Hide
            ann.loraine Ann Loraine added a comment -

            Suggestions for functional review:

            • Obtain a GFF file
            • Add a header line indicating color - select a color that IGB would not show as default
            • Open the file and check it is the requested color

            (Please think of more!)

            Show
            ann.loraine Ann Loraine added a comment - Suggestions for functional review: Obtain a GFF file Add a header line indicating color - select a color that IGB would not show as default Open the file and check it is the requested color (Please think of more!)
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            [~aloraine]

            I have squashed all the changes to a single commit.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - [~aloraine] I have squashed all the changes to a single commit.
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] Reviewing [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Labels Intermediate Advanced
            ann.loraine Ann Loraine made changes -
            Story Points 1 3
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            The functional review was done for this ticket. The code is working fine. It was tested for 3 GFF files with different color indications. The requested color is displayed instead of default in IGB. Kindly submit a pull request for the same.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - The functional review was done for this ticket. The code is working fine. It was tested for 3 GFF files with different color indications. The requested color is displayed instead of default in IGB. Kindly submit a pull request for the same.
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Status Reviewing [ 10301 ] Ready for Pull Request [ 10304 ]
            shamika Shamika Gajanan Kulkarni (Inactive) made changes -
            Assignee Shamika Gajanan Kulkarni [ shamika ] Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Assignee Noor Zahara [ noor91zahara ] Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9, Summer 2019 Sprint 10 [ 68, 69 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 11 [ 68, 69, 70 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            ann.loraine Ann Loraine added a comment -

            Shamika Gajanan Kulkarni or Noor Zahara - please attach or provide a link to GFF3 files with track line used for testing/development.

            Show
            ann.loraine Ann Loraine added a comment - Shamika Gajanan Kulkarni or Noor Zahara - please attach or provide a link to GFF3 files with track line used for testing/development.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            Unable to attach files more than 10 MB.
            The file can be found in the link http://igbquickload.org/smokeTestingQuickload/H_sapiens_Dec_2013/GFF3/
            In the header add ##track name="test" color=255,255,0 in line 2 to test.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Unable to attach files more than 10 MB. The file can be found in the link http://igbquickload.org/smokeTestingQuickload/H_sapiens_Dec_2013/GFF3/ In the header add ##track name="test" color=255,255,0 in line 2 to test.
            Hide
            ann.loraine Ann Loraine added a comment -

            Could you create a smaller version and attach that?
            Otherwise, each time someone has to test the functionality, they will have to download and edit the file.
            Alternatively (maybe this is better?), create a ticket to add such a file to the smoketest quickload site and/or to the test infrastructure files in the project?
            I am working on this today – trying to see if we can support this feature without making lots of changes to the code.
            Seems like track style infrastructure is already available to support color in GFF3 track lines, so I'm looking at how this is working for the other file types in hopes of gaining some insight.

            Show
            ann.loraine Ann Loraine added a comment - Could you create a smaller version and attach that? Otherwise, each time someone has to test the functionality, they will have to download and edit the file. Alternatively (maybe this is better?), create a ticket to add such a file to the smoketest quickload site and/or to the test infrastructure files in the project? I am working on this today – trying to see if we can support this feature without making lots of changes to the code. Seems like track style infrastructure is already available to support color in GFF3 track lines, so I'm looking at how this is working for the other file types in hopes of gaining some insight.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            I am moving this into the next sprint pending simplification of the IGB build system.
            Reason is:
            There are a large number of changes to files, reflecting flaws in our architecture.
            I feel that this many changes – and the massive amount of effort Noor had to expend just to understand what is going on – simply to support foreground color settings coming from the parsed file itself – ought not to have been necessary. I would like dig a little deeper to understand the ways our architecture made this necessary. It should be easier!

            To use an analogy from the building trades: You should not have to install an entirely new wall simply to hang a painting.

            However, our build system is overly complex, with a massive level of technical debt left over from older, more primitive versions of mvn. I think this needs to be improved (simplified and clarified) before attempting any major restructuring or analysis of the data intake (parsing) systems.

            Noor Zahara - please keep your branch "live" on your fork, with the commits as they are. I am going to reject the pull request, but please be aware that this is not a reflection on your work. This is just so that the pull request no longer appears in the pull request queue while we deal with the blocking issue.

            Show
            ann.loraine Ann Loraine added a comment - - edited I am moving this into the next sprint pending simplification of the IGB build system. Reason is: There are a large number of changes to files, reflecting flaws in our architecture. I feel that this many changes – and the massive amount of effort Noor had to expend just to understand what is going on – simply to support foreground color settings coming from the parsed file itself – ought not to have been necessary. I would like dig a little deeper to understand the ways our architecture made this necessary. It should be easier! To use an analogy from the building trades: You should not have to install an entirely new wall simply to hang a painting. However, our build system is overly complex, with a massive level of technical debt left over from older, more primitive versions of mvn. I think this needs to be improved (simplified and clarified) before attempting any major restructuring or analysis of the data intake (parsing) systems. Noor Zahara - please keep your branch "live" on your fork, with the commits as they are. I am going to reject the pull request, but please be aware that this is not a reflection on your work. This is just so that the pull request no longer appears in the pull request queue while we deal with the blocking issue.
            ann.loraine Ann Loraine made changes -
            Link This issue is blocked by IGBF-1829 [ IGBF-1829 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Open [ 1 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 11 [ 68, 69, 70 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 12 [ 68, 69, 71 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Attachment GFF3_HomoSapienChr.zip [ 14383 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked lower
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 12 [ 68, 69, 71 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10, Summer 2019 Sprint 13 [ 68, 69, 72 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked lower
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 18557 ] Fall 2019 Workflow Update [ 18985 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1 [ 68, 69, 72 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1, Fall 2019 Sprint 2 [ 68, 69, 72, 73 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1, Fall 2019 Sprint 2 [ 68, 69, 72, 73 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1, Fall 2019 Sprint 5 [ 68, 69, 72, 75 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1, Fall 2019 Sprint 5 [ 68, 69, 72, 75 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1, Fall 2019 Sprint 6 [ 68, 69, 72, 76 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked lower
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1, Fall 2019 Sprint 5 [ 68, 69, 72, 76 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1, Fall 2019 Sprint 7 [ 68, 69, 72, 78 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 18985 ] Revised Fall 2019 Workflow Update [ 21105 ]
            Status Open [ 1 ] To-Do [ 10305 ]
            ann.loraine Ann Loraine made changes -
            Fix Version/s 9.1.0 Major Release [ 10601 ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1, Fall 7 : 11 Nov to 22 Nov [ 68, 69, 72, 78 ] Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1 [ 68, 69, 72 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]

              People

              • Assignee:
                Unassigned
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: