Details

    • Type: New Feature
    • Status: To-Do (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      3
    • Sprint:
      Summer 2019 Sprint 9, Summer 2019 Sprint 10, Fall 2019 Sprint 1

      Description

      A research at University of Freiburg in Germany has requested better support for setting color schemes for data loaded from GFF files.

      Please see linked issue HELP-321 for details.

        Attachments

          Issue Links

            Activity

            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            The functional review was done for this ticket. The code is working fine. It was tested for 3 GFF files with different color indications. The requested color is displayed instead of default in IGB. Kindly submit a pull request for the same.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - The functional review was done for this ticket. The code is working fine. It was tested for 3 GFF files with different color indications. The requested color is displayed instead of default in IGB. Kindly submit a pull request for the same.
            Hide
            ann.loraine Ann Loraine added a comment -

            Shamika Gajanan Kulkarni or Noor Zahara - please attach or provide a link to GFF3 files with track line used for testing/development.

            Show
            ann.loraine Ann Loraine added a comment - Shamika Gajanan Kulkarni or Noor Zahara - please attach or provide a link to GFF3 files with track line used for testing/development.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            Unable to attach files more than 10 MB.
            The file can be found in the link http://igbquickload.org/smokeTestingQuickload/H_sapiens_Dec_2013/GFF3/
            In the header add ##track name="test" color=255,255,0 in line 2 to test.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Unable to attach files more than 10 MB. The file can be found in the link http://igbquickload.org/smokeTestingQuickload/H_sapiens_Dec_2013/GFF3/ In the header add ##track name="test" color=255,255,0 in line 2 to test.
            Hide
            ann.loraine Ann Loraine added a comment -

            Could you create a smaller version and attach that?
            Otherwise, each time someone has to test the functionality, they will have to download and edit the file.
            Alternatively (maybe this is better?), create a ticket to add such a file to the smoketest quickload site and/or to the test infrastructure files in the project?
            I am working on this today – trying to see if we can support this feature without making lots of changes to the code.
            Seems like track style infrastructure is already available to support color in GFF3 track lines, so I'm looking at how this is working for the other file types in hopes of gaining some insight.

            Show
            ann.loraine Ann Loraine added a comment - Could you create a smaller version and attach that? Otherwise, each time someone has to test the functionality, they will have to download and edit the file. Alternatively (maybe this is better?), create a ticket to add such a file to the smoketest quickload site and/or to the test infrastructure files in the project? I am working on this today – trying to see if we can support this feature without making lots of changes to the code. Seems like track style infrastructure is already available to support color in GFF3 track lines, so I'm looking at how this is working for the other file types in hopes of gaining some insight.
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            I am moving this into the next sprint pending simplification of the IGB build system.
            Reason is:
            There are a large number of changes to files, reflecting flaws in our architecture.
            I feel that this many changes – and the massive amount of effort Noor had to expend just to understand what is going on – simply to support foreground color settings coming from the parsed file itself – ought not to have been necessary. I would like dig a little deeper to understand the ways our architecture made this necessary. It should be easier!

            To use an analogy from the building trades: You should not have to install an entirely new wall simply to hang a painting.

            However, our build system is overly complex, with a massive level of technical debt left over from older, more primitive versions of mvn. I think this needs to be improved (simplified and clarified) before attempting any major restructuring or analysis of the data intake (parsing) systems.

            Noor Zahara - please keep your branch "live" on your fork, with the commits as they are. I am going to reject the pull request, but please be aware that this is not a reflection on your work. This is just so that the pull request no longer appears in the pull request queue while we deal with the blocking issue.

            Show
            ann.loraine Ann Loraine added a comment - - edited I am moving this into the next sprint pending simplification of the IGB build system. Reason is: There are a large number of changes to files, reflecting flaws in our architecture. I feel that this many changes – and the massive amount of effort Noor had to expend just to understand what is going on – simply to support foreground color settings coming from the parsed file itself – ought not to have been necessary. I would like dig a little deeper to understand the ways our architecture made this necessary. It should be easier! To use an analogy from the building trades: You should not have to install an entirely new wall simply to hang a painting. However, our build system is overly complex, with a massive level of technical debt left over from older, more primitive versions of mvn. I think this needs to be improved (simplified and clarified) before attempting any major restructuring or analysis of the data intake (parsing) systems. Noor Zahara - please keep your branch "live" on your fork, with the commits as they are. I am going to reject the pull request, but please be aware that this is not a reflection on your work. This is just so that the pull request no longer appears in the pull request queue while we deal with the blocking issue.

              People

              • Assignee:
                Unassigned
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: