Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2184

Remove code that hides messages after a timeout

        Details

        • Type: Improvement
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          We have code that shows error or info messages at the top of App Store pages for a short time and then removes them.

          This occurs on the Edit App page – possibly other places as well?

          Remove this code. When a message is shown, continue showing it until the user dismisses the message.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-2201 Fix app rating system

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-2185 Remove double-quotes and improve message for " app has been accepted"

              • Major - Major loss of function.
              • Closed

              Sub-task - The sub-task of the issue REL-52 End-to-end testing with SampleSelection(Development-app)

              • Major - Major loss of function.
              • Fix Requested

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2184#diff

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2184#diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Please locate and remove the code that shows a message and then removes it after a short time. This will ensure no-one will use it in future by mistake. Also make sure that code is used anywhere else. You can use a global "grep" to find all instances of same.

                Show
                ann.loraine Ann Loraine added a comment - Please locate and remove the code that shows a message and then removes it after a short time. This will ensure no-one will use it in future by mistake. Also make sure that code is used anywhere else. You can use a global "grep" to find all instances of same.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Re above comment: Look at add_msg method - probably it is the culprit.

                Show
                ann.loraine Ann Loraine added a comment - Re above comment: Look at add_msg method - probably it is the culprit.
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                I have made the necessary changes. Kindly review.

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - I have made the necessary changes. Kindly review.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Changes look good. Can you update the comment? It looks like it may be wrong:

                // type: can be "error", "warning", "success", or "info", or just empty.
                // group: name of the message group; ensures that only one message in the group is shown.

                Show
                ann.loraine Ann Loraine added a comment - Changes look good. Can you update the comment? It looks like it may be wrong: // type: can be "error", "warning", "success", or "info", or just empty. // group: name of the message group; ensures that only one message in the group is shown.
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                The comments seems fine. I have just updated the values of type.

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - The comments seems fine. I have just updated the values of type.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                OK - Noor Zahara please submit PR.

                Show
                ann.loraine Ann Loraine added a comment - OK - Noor Zahara please submit PR.
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                PR Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/190/igbf-2184/diff

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - PR Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/190/igbf-2184/diff
                Hide
                Permalink
                pooja.nikhare Pooja Nikhare (Inactive) added a comment -

                The feature works fine i.e a message is shown until the user dismisses the message .
                But noticed a different behaviour on clicking on rating . The message 'Rating Updated ! Thank you for the input.' is shown only for the unsigned user and not for the logged in User.
                Please review : Noor Zahara , [~aloraine]

                Show
                pooja.nikhare Pooja Nikhare (Inactive) added a comment - The feature works fine i.e a message is shown until the user dismisses the message . But noticed a different behaviour on clicking on rating . The message 'Rating Updated ! Thank you for the input.' is shown only for the unsigned user and not for the logged in User. Please review : Noor Zahara , [~aloraine]
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Pooja Nikhare - thank you for noticing this!

                Show
                ann.loraine Ann Loraine added a comment - Pooja Nikhare - thank you for noticing this!
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Pooja Nikhare - please re-open and move to To-Do. Please add it to the next sprint not the current one.

                Show
                ann.loraine Ann Loraine added a comment - Pooja Nikhare - please re-open and move to To-Do. Please add it to the next sprint not the current one.
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                After investigating, I learned that Pooja Nikhare's observation is not directly related to the code modified in this issue, so I have created a new issue and continued work there: IGBF-2201

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - After investigating, I learned that Pooja Nikhare 's observation is not directly related to the code modified in this issue, so I have created a new issue and continued work there: IGBF-2201

                  People

                  • Assignee:
                    noor91zahara Noor Zahara (Inactive)
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: