Details
-
Type: Task
-
Status: Closed (View Workflow)
-
Priority: Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Spring 2 2022 Jan 18 - Jan 28, Spring 3 2022 Jan 31 - Feb 11, Spring 4 2022 Feb 14 - Feb 25
Description
During a live demo, one of the attendees noticed a problem with a graph operation.
The sum of two graphs did not appear to be correct.
To repeat / investigate:
- Add data source from
IGBF-3064 - Load six scaled coverage graphs from the graphs folder
- Select 3 of the graphs by shift-clicking the left side graph track labels (red outline appears around the label when the graph track is selected)
- Select use the Graph Operations multi-graph menu "Mean" to create a new graph, which is supposed to be the average of the selected graphs
- Repeat the above with another 3 graphs
- Now, subtract the mean graphs from each other
- Check the y-axis values carefully to ensure that the subtraction was correctly done.
Report what you see, along with images showing incorrect or correct behavior.
Attachments
Issue Links
Activity
Ann Loraine
created issue -
Ann Loraine
made changes -
Field | Original Value | New Value |
---|---|---|
Epic Link | IGBF-1765 [ 17855 ] |
Ann Loraine
made changes -
Ann Loraine
made changes -
Description |
During a live demo, one of the attendees noticed a problem with a graph operation.
The sum of two graphs did not appear to be correct. |
During a live demo, one of the attendees noticed a problem with a graph operation.
The sum of two graphs did not appear to be correct. To repeat / investigate: * Add data source from * Load six scaled coverage graphs from the graphs folder * Select 3 of the graphs by shift-clicking the left side graph track labels (red outline appears around the label when the graph track is selected) * Select use the Graph Operations multi-graph menu "Mean" to create a new graph, which is supposed to be the average of the selected graphs * Repeat the above with another 3 graphs * Now, subtract the mean graphs from each other * Check the y-axis values carefully to ensure that the subtraction was correctly done. Report what you see, along with images showing incorrect or correct behavior. |
Omkar Marne (Inactive)
made changes -
Assignee | Omkar Marne [ omarne ] |
Omkar Marne (Inactive)
made changes -
Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean.png [ 17086 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Subtract.png [ 17087 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Subtract.png [ 17088 ] |
Omkar Marne (Inactive)
made changes -
Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Omkar Marne (Inactive)
made changes -
Assignee | Omkar Marne [ omarne ] | Ann Loraine [ aloraine ] |
Omkar Marne (Inactive)
made changes -
Attachment | Addition.png [ 17089 ] |
Ann Loraine
made changes -
Sprint | Spring 2 2022 Jan 18 - Jan 28 [ 137 ] | Spring 2 2022 Jan 18 - Jan 28, Spring 3 2022 Jan 31 - Feb 11 [ 137, 138 ] |
Ann Loraine
made changes -
Rank | Ranked higher |
Ann Loraine
made changes -
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Ann Loraine
made changes -
Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
Ann Loraine
made changes -
Assignee | Ann Loraine [ aloraine ] |
Ann Loraine
made changes -
Assignee | Omkar Marne [ omarne ] |
Ann Loraine
made changes -
Assignee | Omkar Marne [ omarne ] |
Omkar Marne (Inactive)
made changes -
Assignee | Omkar Marne [ omarne ] |
Omkar Marne (Inactive)
made changes -
Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Ann Loraine
made changes -
Sprint | Spring 2 2022 Jan 18 - Jan 28, Spring 3 2022 Jan 31 - Feb 11 [ 137, 138 ] | Spring 2 2022 Jan 18 - Jan 28, Spring 3 2022 Jan 31 - Feb 11, Spring 4 2022 Feb 14 - Feb 25 [ 137, 138, 139 ] |
Ann Loraine
made changes -
Rank | Ranked higher |
Omkar Marne (Inactive)
made changes -
Attachment | Addition.png [ 17089 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean.png [ 17086 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Subtract.png [ 17088 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Subtract.png [ 17087 ] |
Omkar Marne (Inactive)
made changes -
Attachment | y-axis - 1st graph 4085.7.png [ 17176 ] |
Omkar Marne (Inactive)
made changes -
Attachment | y-axis 2nd graph 3389.1.png [ 17177 ] |
Omkar Marne (Inactive)
made changes -
Attachment | y-axis 3rd graph 3707.9.png [ 17178 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean 1st,2nd,3rd 3726.7.png [ 17179 ] |
Omkar Marne (Inactive)
made changes -
Attachment | 4th graph 3499.4.png [ 17180 ] |
Omkar Marne (Inactive)
made changes -
Attachment | 5th graph 4167.3.png [ 17181 ] |
Omkar Marne (Inactive)
made changes -
Attachment | 6th graph 4369.3.png [ 17182 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean 4th,5th,6th - 4012.png [ 17183 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean difference.png [ 17184 ] |
Omkar Marne (Inactive)
made changes -
Comment | [ Mean result, addition result and subtraction result is correct for the selected graphs. Please see attached images. ] |
Omkar Marne (Inactive)
made changes -
Attachment | Subtraction.png [ 17185 ] |
Omkar Marne (Inactive)
made changes -
Attachment | 4th graph 3499.4.png [ 17180 ] |
Omkar Marne (Inactive)
made changes -
Attachment | 5th graph 4167.3.png [ 17181 ] |
Omkar Marne (Inactive)
made changes -
Attachment | 6th graph 4369.3.png [ 17182 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean 1st,2nd,3rd 3726.7.png [ 17179 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean 4th,5th,6th - 4012.png [ 17183 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean difference.png [ 17184 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Subtraction.png [ 17185 ] |
Omkar Marne (Inactive)
made changes -
Attachment | y-axis - 1st graph 4085.7.png [ 17176 ] |
Omkar Marne (Inactive)
made changes -
Attachment | y-axis 2nd graph 3389.1.png [ 17177 ] |
Omkar Marne (Inactive)
made changes -
Attachment | y-axis 3rd graph 3707.9.png [ 17178 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean 1.png [ 17186 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean 1.png [ 17186 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean 1.png [ 17187 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Mean 2.png [ 17188 ] |
Omkar Marne (Inactive)
made changes -
Attachment | Difference.png [ 17189 ] |
Omkar Marne (Inactive)
made changes -
Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Omkar Marne (Inactive)
made changes -
Assignee | Omkar Marne [ omarne ] | Ann Loraine [ aloraine ] |
Ann Loraine
made changes -
Assignee | Ann Loraine [ aloraine ] |
Nowlan Freese
made changes -
Assignee | Nowlan Freese [ nfreese ] |
Nowlan Freese
made changes -
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Nowlan Freese
made changes -
Attachment | 48738118.png [ 17190 ] |
Nowlan Freese
made changes -
Assignee | Nowlan Freese [ nfreese ] |
Nowlan Freese
made changes -
Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
Nowlan Freese
made changes -
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Nowlan Freese
made changes -
Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
Nowlan Freese
made changes -
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Nowlan Freese
made changes -
Assignee | Nowlan Freese [ nfreese ] |
Nowlan Freese
made changes -
Nowlan Freese
made changes -
Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
Nowlan Freese
made changes -
Assignee | Nowlan Freese [ nfreese ] | Ann Loraine [ aloraine ] |
Nowlan Freese
made changes -
Assignee | Ann Loraine [ aloraine ] |
Nowlan Freese
made changes -
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Nowlan Freese
made changes -
Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
Nowlan Freese
made changes -
Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Nowlan Freese
made changes -
Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Nowlan Freese
made changes -
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Ann Loraine
made changes -
Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Ann Loraine
made changes -
Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Ann Loraine
made changes -
Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
Ann Loraine
made changes -
Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Ann Loraine
made changes -
Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Ann Loraine
made changes -
Resolution | Done [ 10000 ] | |
Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Ann Loraine
made changes -
Assignee | Omkar Marne [ omarne ] |
Nowlan Freese
made changes -
Summary | Investigate graph addition problem | Replicate graph addition problem |
Nowlan Freese
made changes -
I am not seeing evidence in the images of correct values. The view is too zoomed-out to investigate individual values at the individual base pair level.
For next step, we need to look more closely at image file scaledcoveragegraphs-ARE-chr1-diff-problem.png from the linked ticket
IGBF-3064.Please load the same scene and investigate. Do the y-axis values make sense? Check the "diff" graph track, which is supposed to be the subtraction of one computed mean track minus the other.